[PATCH 04/52] gdbv850sim/console/console-io.c: Fix warnings

[Joel Sherrill]

All of the BSPs using console-polled.c will be addressed by a single
patch in the next revision.  I added <bsp/console-polled.h>, included
it from the appropriate driver, and added static to the printk()
support method in all 14 BSPs.  That should clobber a few more
warnings.

--joel
On 10/8/2014 3:26 PM, Gedare Bloom wrote:
> On Wed, Oct 8, 2014 at 4:20 PM, Joel Sherrill <joel.sherrill at oarcorp.com> wrote:
>> On 10/8/2014 3:10 PM, Gedare Bloom wrote:
>>> On Wed, Oct 8, 2014 at 3:15 PM, Joel Sherrill <joel.sherrill at oarcorp.com> wrote:
>>>> ---
>>>>  c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c | 9 ++++++++-
>>>>  1 file changed, 8 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c b/c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c
>>>> index c178197..a66c800 100644
>>>> --- a/c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c
>>>> +++ b/c/src/lib/libbsp/v850/gdbv850sim/console/console-io.c
>>>> @@ -12,6 +12,14 @@
>>>>  #include <bsp/syscall.h>
>>>>
>>>>  /*
>>>> + * Prototypes
>>>> + */
>>>> +void console_initialize_hardware(void);
>>>> +void console_outbyte_polled(int  port, char ch);
>>>> +int console_inbyte_nonblocking(int port);
>>>> +void console_output_char(char c);
>>>> +
>>> These prototype additions should go to a header file, or the functions
>>> should be made static.
>> The first three are the assumed interface for the single port
>> polled console driver framework.  They can't be static.
>>
>> c/src/lib/libbsp/shared/console-polled.c
>>
>> Any suggestions for a new header file to add them to?
>> I suppose we could add console-polled.h for private use?
> Sure.
>
>> FWIW Adding this will impact 14 BSPs and likely fix 3*14 warnings.
>> But only one other patch (0013-gdbamsim).
>>
>> The fourth should be able to be static. I should have caught that.
>>>> +/*
>>>>   *  console_initialize_hardware
>>>>   *
>>>>   *  This routine initializes the console hardware.
>>>> @@ -38,7 +46,6 @@ void console_outbyte_polled(
>>>>   *
>>>>   *  This routine polls for a character.
>>>>   */
>>>> -
>>>>  int console_inbyte_nonblocking(
>>>>    int port
>>>>  )
>>>> --
>>>> 1.9.3
>>>>
>>>> _______________________________________________
>>>> devel mailing list
>>>> devel at rtems.org
>>>> http://lists.rtems.org/mailman/listinfo/devel
>> --
>> Joel Sherrill, Ph.D.             Director of Research & Development
>> joel.sherrill at OARcorp.com        On-Line Applications Research
>> Ask me about RTEMS: a free RTOS  Huntsville AL 35805
>> Support Available                (256) 722-9985
>>
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel

-- 
Joel Sherrill, Ph.D.             Director of Research & Development
joel.sherrill at OARcorp.com        On-Line Applications Research
Ask me about RTEMS: a free RTOS  Huntsville AL 35805
Support Available                (256) 722-9985