[rtems commit] libmisc/shell: Remove the need for -lm when linking from the ping command.

Chris Johns chrisj at rtems.org
Sat Oct 4 01:33:30 UTC 2014


On 4/10/2014 10:05 am, Gedare Bloom wrote:
> On Fri, Oct 3, 2014 at 8:04 PM, Gedare Bloom <gedare at rtems.org> wrote:
>> On Fri, Oct 3, 2014 at 6:48 PM, Chris Johns <chrisj at rtems.org> wrote:
>>> Module:    rtems
>>> Branch:    master
>>> Commit:    56ed56a641b69be42f5a38046307b33096014c84
>>> Changeset: http://git.rtems.org/rtems/commit/?id=56ed56a641b69be42f5a38046307b33096014c84
>>>
>>> Author:    Chris Johns <chrisj at rtems.org>
>>> Date:      Sat Oct  4 08:55:12 2014 +1000
>>>
>>> libmisc/shell: Remove the need for -lm when linking from the ping command.
>>>
>>> Remove the use of sqrt and so the need to link to -lm.
>>> Clean up some warnings.
>>>
>>>   static void
>>>   g_check_status(globals)
>>> @@ -1638,10 +1639,16 @@ g_finish(globals)
>>>          if (nreceived && timing) {
>>>                  double n = nreceived + nrepeats;
>>>                  double avg = tsum / n;
>>> +#if defined(__rtems__)
>>> +               (void) printf(
>>> +                   "round-trip min/avg/max/stddev = %.3f/%.3f/%.3f ms\n",
>> Remove "/stddev"?
> Actually, I'd suggest to just print the variance as it can be computed
> relatively cheaply (compared to sqrt).
>

Ah yes I can change this. There is another step to remove the use of 
floating point which Pavel raised and I think is a great idea. This is 
just a simple clean up while that can be done.

Chris



More information about the devel mailing list