[PATCH 28/54] libbsp/lm32/shared: Fix warnings

Joel Sherrill joel.sherrill at oarcorp.com
Mon Oct 13 15:37:12 UTC 2014


---
 c/src/lib/libbsp/lm32/shared/clock/ckinit.c    | 12 +++---
 c/src/lib/libbsp/lm32/shared/console/console.c | 52 +++-----------------------
 2 files changed, 11 insertions(+), 53 deletions(-)

diff --git a/c/src/lib/libbsp/lm32/shared/clock/ckinit.c b/c/src/lib/libbsp/lm32/shared/clock/ckinit.c
index 064b93f..ae065de 100644
--- a/c/src/lib/libbsp/lm32/shared/clock/ckinit.c
+++ b/c/src/lib/libbsp/lm32/shared/clock/ckinit.c
@@ -1,7 +1,8 @@
-/*  ckinit.c
- *
+/*
  *  Clock device driver for Lattice Mico32 (lm32).
- *
+ */
+
+/*
  *  COPYRIGHT (c) 1989-2009.
  *  On-Line Applications Research Corporation (OAR).
  *
@@ -36,7 +37,6 @@ static inline void clockwrite(unsigned int reg, int value)
  *  The interrupt vector number associated with the clock tick device
  *  driver.
  */
-
 #define CLOCK_VECTOR    ( TIMER0_IRQ )
 #define CLOCK_IRQMASK   ( 1 << CLOCK_VECTOR )
 
@@ -52,7 +52,7 @@ static inline void clockwrite(unsigned int reg, int value)
     _old = (rtems_isr_entry) set_vector( _new, CLOCK_VECTOR, 1 ); \
   } while (0)
 
-void Clock_driver_support_initialize_hardware(void)
+static void Clock_driver_support_initialize_hardware(void)
 {
   /* Set clock period */
   clockwrite(LM32_CLOCK_PERIOD,
@@ -67,7 +67,7 @@ void Clock_driver_support_initialize_hardware(void)
   lm32_interrupt_unmask(CLOCK_IRQMASK);
 }
 
-void Clock_driver_support_shutdown_hardware(void)
+static void Clock_driver_support_shutdown_hardware(void)
 {
   /* Disable clock interrupts and stop */
 
diff --git a/c/src/lib/libbsp/lm32/shared/console/console.c b/c/src/lib/libbsp/lm32/shared/console/console.c
index 2cbbd1b..233555c 100644
--- a/c/src/lib/libbsp/lm32/shared/console/console.c
+++ b/c/src/lib/libbsp/lm32/shared/console/console.c
@@ -1,6 +1,8 @@
 /*
  *  Console driver for Lattice Mico32 (lm32).
- *
+ */
+
+/*
  *  COPYRIGHT (c) 1989-1999.
  *  On-Line Applications Research Corporation (OAR).
  *
@@ -25,14 +27,7 @@ char BSP_uart_is_character_ready(char *ch);
 /*  console_initialize
  *
  *  This routine initializes the console IO driver.
- *
- *  Input parameters: NONE
- *
- *  Output parameters:  NONE
- *
- *  Return values:
  */
-
 rtems_device_driver console_initialize(
   rtems_device_major_number  major,
   rtems_device_minor_number  minor,
@@ -55,37 +50,11 @@ rtems_device_driver console_initialize(
   return RTEMS_SUCCESSFUL;
 }
 
-/*  is_character_ready
- *
- *  This routine returns TRUE if a character is available.
- *
- *  Input parameters: NONE
- *
- *  Output parameters:  NONE
- *
- *  Return values:
- */
-
-bool is_character_ready(
-  char *ch
-)
-{
-  return BSP_uart_is_character_ready(ch);
-}
-
 /*  inbyte
  *
  *  This routine reads a character from the SOURCE.
- *
- *  Input parameters: NONE
- *
- *  Output parameters:  NONE
- *
- *  Return values:
- *    character read from SOURCE
  */
-
-int inbyte( void )
+static int inbyte( void )
 {
   /*
    *  If polling, wait until a character is available.
@@ -98,14 +67,8 @@ int inbyte( void )
  *
  *  This routine transmits a character out the SOURCE.  It may support
  *  XON/XOFF flow control.
- *
- *  Input parameters:
- *    ch  - character to be transmitted
- *
- *  Output parameters:  NONE
  */
-
-void outbyte(
+static void outbyte(
   char ch
 )
 {
@@ -121,7 +84,6 @@ void outbyte(
 /*
  *  Open entry point
  */
-
 rtems_device_driver console_open(
   rtems_device_major_number major,
   rtems_device_minor_number minor,
@@ -134,7 +96,6 @@ rtems_device_driver console_open(
 /*
  *  Close entry point
  */
-
 rtems_device_driver console_close(
   rtems_device_major_number major,
   rtems_device_minor_number minor,
@@ -147,7 +108,6 @@ rtems_device_driver console_close(
 /*
  * read bytes from the serial port. We only have stdin.
  */
-
 rtems_device_driver console_read(
   rtems_device_major_number major,
   rtems_device_minor_number minor,
@@ -179,7 +139,6 @@ rtems_device_driver console_read(
 /*
  * write bytes to the serial port. Stdout and stderr are the same.
  */
-
 rtems_device_driver console_write(
   rtems_device_major_number major,
   rtems_device_minor_number minor,
@@ -210,7 +169,6 @@ rtems_device_driver console_write(
 /*
  *  IO Control entry point
  */
-
 rtems_device_driver console_control(
   rtems_device_major_number major,
   rtems_device_minor_number minor,
-- 
1.9.3




More information about the devel mailing list