[PATCH] smptests/smpcache01: Disable SMP cache manager test when not applicable

[Sebastian Huber]

On 01/09/14 13:15, Daniel Cederman wrote:
> ---
>   testsuites/smptests/smpcache01/init.c | 29 ++++++++++++++++++++++++++---
>   1 file changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/testsuites/smptests/smpcache01/init.c b/testsuites/smptests/smpcache01/init.c
> index dd2f9f1..48154d4 100644
> --- a/testsuites/smptests/smpcache01/init.c
> +++ b/testsuites/smptests/smpcache01/init.c
> @@ -20,6 +20,8 @@
>
>   const char rtems_test_name[] = "SMPCACHE 1";
>
> +char test_is_applicable = 1;
> +

Why is this not a bool, and why is this not static?

>   #define CPU_COUNT 32
>
>   #define WORKER_PRIORITY 100
> @@ -33,7 +35,19 @@ _Cache_manager_Send_smp_msg(
>       Cache_manager_Function_ptr func,
>       const void * addr,
>       size_t size
> -  );
> +  ) __attribute__((weak));

Before we start to use weak functions in the testsuite, we should add an 
attribute macro to basedefs.h and generally agree, that weak functions are 
acceptable for RTEMS in general.

An alternative solution to this hack would be to turn the cache manager message 
operations into general purpose message operations for SMP so that it can be 
used for other things and not just the cache manager.  Basically you created a 
means to execute a function on all processors of a set and wait for completion 
on all processors of a set.

[...]

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.