[PATCH 2/4] pc386/.../bsp.h: Do not include crt.h

Joel Sherrill joel.sherrill at oarcorp.com
Thu Sep 11 13:28:15 UTC 2014


crt.h defines such lovely constants as "RED" and "GREEN" which
have a nasty habit of conflicting with non-BSP code. There is
no reason to include this private .h from bsp.h and pollute the
namespace for applications.
---
 c/src/lib/libbsp/i386/pc386/include/bsp.h | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/c/src/lib/libbsp/i386/pc386/include/bsp.h b/c/src/lib/libbsp/i386/pc386/include/bsp.h
index cb9555a..ef16b4a 100644
--- a/c/src/lib/libbsp/i386/pc386/include/bsp.h
+++ b/c/src/lib/libbsp/i386/pc386/include/bsp.h
@@ -113,12 +113,6 @@ extern int rtems_3c509_driver_attach(struct rtems_bsdnet_ifconfig *config);
 +--------------------------------------------------------------------------*/
 
 /*-------------------------------------------------------------------------+
-| Video (console) related constants.
-+--------------------------------------------------------------------------*/
-
-#include <crt.h>
-
-/*-------------------------------------------------------------------------+
 | Constants relating to the 8254 (or 8253) programmable interval timers.
 +--------------------------------------------------------------------------*/
 #define IO_TIMER1      0x40
-- 
1.9.3




More information about the devel mailing list