[PATCH] Beagle BSP Improvements (GPIO driver)

[Ben Gras]

All,

Good contribution, thank you.

For GSOC, this is good proof of being able to progress and get
something real working based on documentation. Great!

If you want this merged with mainline - which I fully encourage! -
then I suggest the following should be added to/changed first:

  - make the code that uses AM335X (beaglebone) specific registers,
AM335X-specific :) i.e. add  #if IS_AM335X around code that should
only execute there. this BSP can be compiled for 2 different SOCs.
  - let it control all GPIO's - there are 4 banks of 32 each on the
AM335x, but you only let the user control GPIO1. there should be a
clean interface to control them all (clean means mostly: without
duplicating code)
  - as Gedare mentioned on IRC, copy the RPi API. this is a first
(second?) step to finding a generalized GPIO API.
  - don't add beagleboard.h, but add your definitions to
libcpu/arm/shared/include/am335x.h
  - the code should use a more consistent indenting style, and make
variable names more descriptive than 'tmp'.
  - don't leave the configure changes in like in acinclude.m4

bonus:
  - add DM3730 (beagleboard) support.

Good luck!


On Fri, Apr 17, 2015 at 7:51 PM, Ketul Shah <ketulshah1993 at gmail.com> wrote:
> Hello,
>
> I have proposed in GSoC on Beagle BSP Improvements. As starting I started
> working for gpio driver development . At this stage I am able to demonstrate
> USR LEDs pattern.
>
> Videos of that can be found here on YouTube.
> https://youtu.be/B3mSsfo-PAQ &
> https://youtu.be/M1aKpOhUvv4.
>
> Herewith I have attached patch.txt file. Alternatively you can have
> https://gist.github.com/ketul93/2e0d2c4b8b586be62e1d that includes the newly
> added files code. I would be happy to hear your reviews and changes on my
> work.
>
> And also I have been updating my work on
> https://github.com/ketul93/RTEMS-on-BBB repo.
>
> It would be great to have your comments on my proposal.
>
> Thanks and regards,
> ketul
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel