[PATCH] Fix or1k C++ build failure

Emil Nordling emil.nordling at gmail.com
Mon Apr 27 13:10:50 UTC 2015


Great!

If I'm not mistaken, cdtest should mention calling global ctors, local
ctors, local dtors and global dtors. Somewhere in between there is a
section testing exceptions. If it ends with the "header"-printout for the
exceptions, the global initialization is missing.

Regards,
/Emil Nordling

On Mon, Apr 27, 2015 at 2:51 PM Hesham ALMatary <heshamelmatary at gmail.com>
wrote:

> On Mon, Apr 27, 2015 at 12:17 PM, Emil Nordling <emil.nordling at gmail.com>
> wrote:
> > Will this fix global ctor/dtor's? (Tested e.g. by compiling and running
> > testsuites/samples/cdtest in or1ksim.)
> cdtest is built and compiled fine, it's also running but I'm not sure
> if it behaves properly.
> >
> > Regards,
> > /Emil Nordling
> > On Mon, Apr 27, 2015 at 12:51 PM <devel-request at rtems.org> wrote:
> >>
> >> Send devel mailing list submissions to
> >>         devel at rtems.org
> >>
> >> To subscribe or unsubscribe via the World Wide Web, visit
> >>         http://lists.rtems.org/mailman/listinfo/devel
> >> or, via email, send a message with subject or body 'help' to
> >>         devel-request at rtems.org
> >>
> >> You can reach the person managing the list at
> >>         devel-owner at rtems.org
> >>
> >> When replying, please edit your Subject line so it is more specific
> >> than "Re: Contents of devel digest..."
> >>
> >>
> >> Today's Topics:
> >>
> >>    1. [PATCH] Fix or1k C++ build failure (Hesham ALMatary)
> >>    2. 4.11 Branching (Joel Sherrill)
> >>    3. Re: 4.11 Branching (Chris Johns)
> >>    4. Re: 4.11 Branching (Joel Sherrill)
> >>    5. Re: [rtems commit] Fix or1k C++ build failure (Sebastian Huber)
> >>    6. Re: [rtems commit] Fix or1k C++ build failure (Hesham ALMatary)
> >>    7. Re: [rtems commit] Fix or1k C++ build failure (Hesham ALMatary)
> >>    8. Re: [rtems commit] Fix or1k C++ build failure (Sebastian Huber)
> >>    9. Re: 4.11 Branching (Sebastian Huber)
> >>   10. [PATCH] [RSB] or1k: correct the md5 hash of the GCC patch
> >>       (Hesham ALMatary)
> >>
> >>
> >> ----------------------------------------------------------------------
> >>
> >> Message: 1
> >> Date: Sun, 26 Apr 2015 17:28:08 +0100
> >> From: Hesham ALMatary <heshamelmatary at gmail.com>
> >> To: devel at rtems.org
> >> Subject: [PATCH] Fix or1k C++ build failure
> >> Message-ID:
> >>         <1430065688-18143-1-git-send-email-heshamelmatary at gmail.com>
> >>
> >> Closes #2329
> >> ---
> >>  c/src/lib/libbsp/or1k/generic_or1k/start/start.S | 7 +++++++
> >>  1 file changed, 7 insertions(+)
> >>
> >> diff --git a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> index d951a55..ae6d41a 100644
> >> --- a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> +++ b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> @@ -180,3 +180,10 @@ _end_clear_bss:
> >>
> >>  unhandled_exception:
> >>    l.nop
> >> +
> >> +/* Make C++ compiler happy */
> >> +.section .data
> >> +.global __dso_handle
> >> +.weak   __dso_handle
> >> +__dso_handle:
> >> +.long 0
> >> --
> >> 2.1.0
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 2
> >> Date: Sun, 26 Apr 2015 20:15:04 -0500
> >> From: Joel Sherrill <joel.sherrill at oarcorp.com>
> >> To: "devel at rtems.org" <devel at rtems.org>
> >> Subject: 4.11 Branching
> >> Message-ID: <2EDD6976-780E-4172-B49F-F60D9E029471 at oarcorp.com>
> >> Content-Type: text/plain; charset="UTF-8"
> >>
> >> Hi
> >>
> >> I have a fix in the test queue for the build breakages I reported last
> >> week. Hesham fixed C++ on the or1k.
> >>
> >> I need to bump the dates on the documentation before branching.
> >>
> >> I had the impression Sebastian wanted to merge one more patch set. Is
> this
> >> true?
> >>
> >> Anything else?
> >> --joel
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 3
> >> Date: Mon, 27 Apr 2015 11:41:34 +1000
> >> From: Chris Johns <chrisj at rtems.org>
> >> To: Joel Sherrill <joel.sherrill at oarcorp.com>, "devel at rtems.org"
> >>         <devel at rtems.org>
> >> Subject: Re: 4.11 Branching
> >> Message-ID: <553D93CE.9040003 at rtems.org>
> >> Content-Type: text/plain; charset=windows-1252
> >>
> >> On 27/04/2015 11:15 am, Joel Sherrill wrote:
> >> >
> >> > Anything else?
> >>
> >> I have a change for the cpuuse top command to correctly display the
> >> current usage rather than the total usage. This is not a bug fix as such
> >> so I am not sure it is ok to go in.
> >>
> >> Chris
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 4
> >> Date: Sun, 26 Apr 2015 20:44:13 -0500
> >> From: Joel Sherrill <joel.sherrill at oarcorp.com>
> >> To: Chris Johns <chrisj at rtems.org>,"devel at rtems.org" <devel at rtems.org>
> >> Subject: Re: 4.11 Branching
> >> Message-ID: <7D1AE1B5-1ED9-48C7-BCE4-ED5927B649FA at oarcorp.com>
> >> Content-Type: text/plain; charset="UTF-8"
> >>
> >>
> >>
> >> On April 26, 2015 8:41:34 PM CDT, Chris Johns <chrisj at rtems.org> wrote:
> >> >On 27/04/2015 11:15 am, Joel Sherrill wrote:
> >> >>
> >> >> Anything else?
> >> >
> >> >I have a change for the cpuuse top command to correctly display the
> >> >current usage rather than the total usage. This is not a bug fix as
> >> >such
> >> >so I am not sure it is ok to go in.
> >>
> >> It's ok to merge it. Top is new so fixing something is ok. Just timing
> on
> >> when it is ready.
> >>
> >> >Chris
> >>
> >> --joel
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 5
> >> Date: Mon, 27 Apr 2015 08:48:38 +0200
> >> From: Sebastian Huber <sebastian.huber at embedded-brains.de>
> >> To: "rtems-devel at rtems.org" <devel at rtems.org>
> >> Subject: Re: [rtems commit] Fix or1k C++ build failure
> >> Message-ID: <553DDBC6.9040403 at embedded-brains.de>
> >> Content-Type: text/plain; charset=windows-1252; format=flowed
> >>
> >> I doubt that this fix is correct. This variable is usually defined in
> >> the GCC libgcc/crtstuff.c file. I guess something is wrong with the GCC
> >> configuration for this target.
> >>
> >> On 26/04/15 21:56, Joel Sherril wrote:
> >> > Module:    rtems
> >> > Branch:    master
> >> > Commit:    3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> > Changeset:
> >> >
> http://git.rtems.org/rtems/commit/?id=3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> >
> >> > Author:    Hesham ALMatary <heshamelmatary at gmail.com>
> >> > Date:      Sun Apr 26 11:28:08 2015 -0500
> >> >
> >> > Fix or1k C++ build failure
> >> >
> >> > Closes #2329
> >> >
> >> > ---
> >> >
> >> >   c/src/lib/libbsp/or1k/generic_or1k/start/start.S | 7 +++++++
> >> >   1 file changed, 7 insertions(+)
> >> >
> >> > diff --git a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> > b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> > index d951a55..ae6d41a 100644
> >> > --- a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> > +++ b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> > @@ -180,3 +180,10 @@ _end_clear_bss:
> >> >
> >> >   unhandled_exception:
> >> >     l.nop
> >> > +
> >> > +/* Make C++ compiler happy */
> >> > +.section .data
> >> > +.global __dso_handle
> >> > +.weak   __dso_handle
> >> > +__dso_handle:
> >> > +.long 0
> >> >
> >> > _______________________________________________
> >> > vc mailing list
> >> > vc at rtems.org
> >> > http://lists.rtems.org/mailman/listinfo/vc
> >>
> >> --
> >> Sebastian Huber, embedded brains GmbH
> >>
> >> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> >> Phone   : +49 89 189 47 41-16
> >> Fax     : +49 89 189 47 41-09
> >> E-Mail  : sebastian.huber at embedded-brains.de
> >> PGP     : Public key available on request.
> >>
> >> Diese Nachricht ist keine gesch?ftliche Mitteilung im Sinne des EHUG.
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 6
> >> Date: Mon, 27 Apr 2015 08:21:51 +0100
> >> From: Hesham ALMatary <heshamelmatary at gmail.com>
> >> To: Sebastian Huber <sebastian.huber at embedded-brains.de>
> >> Cc: "rtems-devel at rtems.org" <devel at rtems.org>
> >> Subject: Re: [rtems commit] Fix or1k C++ build failure
> >> Message-ID:
> >>
> >> <CA+wsVCAOiQSjWLN3qYmb8bnNQ3sm570RL_HUKxQkidbp7hz5NQ at mail.gmail.com>
> >> Content-Type: text/plain; charset=UTF-8
> >>
> >> On Mon, Apr 27, 2015 at 7:48 AM, Sebastian Huber
> >> <sebastian.huber at embedded-brains.de> wrote:
> >> > I doubt that this fix is correct. This variable is usually defined in
> >> > the
> >> > GCC libgcc/crtstuff.c file. I guess something is wrong with the GCC
> >> > configuration for this target.
> >> >
> >> I imitated what's in gdbv850sim/start/start.S. I'll check the GCC side.
> >> > On 26/04/15 21:56, Joel Sherril wrote:
> >> >>
> >> >> Module:    rtems
> >> >> Branch:    master
> >> >> Commit:    3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> >> Changeset:
> >> >>
> >> >>
> http://git.rtems.org/rtems/commit/?id=3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> >>
> >> >> Author:    Hesham ALMatary <heshamelmatary at gmail.com>
> >> >> Date:      Sun Apr 26 11:28:08 2015 -0500
> >> >>
> >> >> Fix or1k C++ build failure
> >> >>
> >> >>
> >> >> Closes #2329
> >> >>
> >> >> ---
> >> >>
> >> >>   c/src/lib/libbsp/or1k/generic_or1k/start/start.S | 7 +++++++
> >> >>   1 file changed, 7 insertions(+)
> >> >>
> >> >> diff --git a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >> b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >> index d951a55..ae6d41a 100644
> >> >> --- a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >> +++ b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >> @@ -180,3 +180,10 @@ _end_clear_bss:
> >> >>     unhandled_exception:
> >> >>     l.nop
> >> >> +
> >> >> +/* Make C++ compiler happy */
> >> >> +.section .data
> >> >> +.global __dso_handle
> >> >> +.weak   __dso_handle
> >> >> +__dso_handle:
> >> >> +.long 0
> >> >>
> >> >> _______________________________________________
> >> >> vc mailing list
> >> >> vc at rtems.org
> >> >> http://lists.rtems.org/mailman/listinfo/vc
> >> >
> >> >
> >> > --
> >> > Sebastian Huber, embedded brains GmbH
> >> >
> >> > Address : Dornierstr. 4, D-82178 Puchheim, Germany
> >> > Phone   : +49 89 189 47 41-16
> >> > Fax     : +49 89 189 47 41-09
> >> > E-Mail  : sebastian.huber at embedded-brains.de
> >> > PGP     : Public key available on request.
> >> >
> >> > Diese Nachricht ist keine gesch?ftliche Mitteilung im Sinne des EHUG.
> >> >
> >>
> >>
> >>
> >> --
> >> Hesham
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 7
> >> Date: Mon, 27 Apr 2015 08:44:12 +0100
> >> From: Hesham ALMatary <heshamelmatary at gmail.com>
> >> To: Sebastian Huber <sebastian.huber at embedded-brains.de>
> >> Cc: "rtems-devel at rtems.org" <devel at rtems.org>
> >> Subject: Re: [rtems commit] Fix or1k C++ build failure
> >> Message-ID:
> >>
> >> <CA+wsVCBEbCmGUeu4X3Kd3ReB9Lw9u=KipkGpSZq-iCFA2pWRWw at mail.gmail.com>
> >> Content-Type: text/plain; charset=UTF-8
> >>
> >> It's not defined anywhere at libgcc/config/or1k/crt*. I can add it to
> >> libgcc/config/or1k/crti.S but I'm not sure this will also be correct.
> >>
> >> On Mon, Apr 27, 2015 at 8:21 AM, Hesham ALMatary
> >> <heshamelmatary at gmail.com> wrote:
> >> > On Mon, Apr 27, 2015 at 7:48 AM, Sebastian Huber
> >> > <sebastian.huber at embedded-brains.de> wrote:
> >> >> I doubt that this fix is correct. This variable is usually defined in
> >> >> the
> >> >> GCC libgcc/crtstuff.c file. I guess something is wrong with the GCC
> >> >> configuration for this target.
> >> >>
> >> > I imitated what's in gdbv850sim/start/start.S. I'll check the GCC
> side.
> >> >> On 26/04/15 21:56, Joel Sherril wrote:
> >> >>>
> >> >>> Module:    rtems
> >> >>> Branch:    master
> >> >>> Commit:    3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> >>> Changeset:
> >> >>>
> >> >>>
> http://git.rtems.org/rtems/commit/?id=3dead51eddcdb734b36c949cbc1e4c2cd21c52d4
> >> >>>
> >> >>> Author:    Hesham ALMatary <heshamelmatary at gmail.com>
> >> >>> Date:      Sun Apr 26 11:28:08 2015 -0500
> >> >>>
> >> >>> Fix or1k C++ build failure
> >> >>>
> >> >>>
> >> >>> Closes #2329
> >> >>>
> >> >>> ---
> >> >>>
> >> >>>   c/src/lib/libbsp/or1k/generic_or1k/start/start.S | 7 +++++++
> >> >>>   1 file changed, 7 insertions(+)
> >> >>>
> >> >>> diff --git a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >>> b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >>> index d951a55..ae6d41a 100644
> >> >>> --- a/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >>> +++ b/c/src/lib/libbsp/or1k/generic_or1k/start/start.S
> >> >>> @@ -180,3 +180,10 @@ _end_clear_bss:
> >> >>>     unhandled_exception:
> >> >>>     l.nop
> >> >>> +
> >> >>> +/* Make C++ compiler happy */
> >> >>> +.section .data
> >> >>> +.global __dso_handle
> >> >>> +.weak   __dso_handle
> >> >>> +__dso_handle:
> >> >>> +.long 0
> >> >>>
> >> >>> _______________________________________________
> >> >>> vc mailing list
> >> >>> vc at rtems.org
> >> >>> http://lists.rtems.org/mailman/listinfo/vc
> >> >>
> >> >>
> >> >> --
> >> >> Sebastian Huber, embedded brains GmbH
> >> >>
> >> >> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> >> >> Phone   : +49 89 189 47 41-16
> >> >> Fax     : +49 89 189 47 41-09
> >> >> E-Mail  : sebastian.huber at embedded-brains.de
> >> >> PGP     : Public key available on request.
> >> >>
> >> >> Diese Nachricht ist keine gesch?ftliche Mitteilung im Sinne des EHUG.
> >> >>
> >> >
> >> >
> >> >
> >> > --
> >> > Hesham
> >>
> >>
> >>
> >> --
> >> Hesham
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 8
> >> Date: Mon, 27 Apr 2015 09:48:51 +0200
> >> From: Sebastian Huber <sebastian.huber at embedded-brains.de>
> >> To: Hesham ALMatary <heshamelmatary at gmail.com>
> >> Cc: "rtems-devel at rtems.org" <devel at rtems.org>
> >> Subject: Re: [rtems commit] Fix or1k C++ build failure
> >> Message-ID: <553DE9E3.4040202 at embedded-brains.de>
> >> Content-Type: text/plain; charset=utf-8; format=flowed
> >>
> >>
> >>
> >> On 27/04/15 09:44, Hesham ALMatary wrote:
> >> > It's not defined anywhere at libgcc/config/or1k/crt*. I can add it to
> >> > libgcc/config/or1k/crti.S but I'm not sure this will also be correct.
> >>
> >> It is defined in libgcc/crtstuff.c. The target must define
> >> INIT_SECTION_ASM_OP or INIT_ARRAY_SECTION_ASM_OP somehow.
> >>
> >> --
> >> Sebastian Huber, embedded brains GmbH
> >>
> >> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> >> Phone   : +49 89 189 47 41-16
> >> Fax     : +49 89 189 47 41-09
> >> E-Mail  : sebastian.huber at embedded-brains.de
> >> PGP     : Public key available on request.
> >>
> >> Diese Nachricht ist keine gesch?ftliche Mitteilung im Sinne des EHUG.
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 9
> >> Date: Mon, 27 Apr 2015 10:32:56 +0200
> >> From: Sebastian Huber <sebastian.huber at embedded-brains.de>
> >> To: Joel Sherrill <joel.sherrill at oarcorp.com>,  "devel at rtems.org"
> >>         <devel at rtems.org>
> >> Subject: Re: 4.11 Branching
> >> Message-ID: <553DF438.3030302 at embedded-brains.de>
> >> Content-Type: text/plain; charset=windows-1252; format=flowed
> >>
> >>
> >>
> >> On 27/04/15 03:15, Joel Sherrill wrote:
> >> > I had the impression Sebastian wanted to merge one more patch set. Is
> >> > this true?
> >>
> >> I checked in some fixes for the cache manager and the cache support for
> >> SPARC. That's all for now.
> >>
> >> --
> >> Sebastian Huber, embedded brains GmbH
> >>
> >> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> >> Phone   : +49 89 189 47 41-16
> >> Fax     : +49 89 189 47 41-09
> >> E-Mail  : sebastian.huber at embedded-brains.de
> >> PGP     : Public key available on request.
> >>
> >> Diese Nachricht ist keine gesch?ftliche Mitteilung im Sinne des EHUG.
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Message: 10
> >> Date: Mon, 27 Apr 2015 11:51:16 +0100
> >> From: Hesham ALMatary <heshamelmatary at gmail.com>
> >> To: devel at rtems.org
> >> Subject: [PATCH] [RSB] or1k: correct the md5 hash of the GCC patch
> >> Message-ID:
> >>         <1430131876-19517-1-git-send-email-heshamelmatary at gmail.com>
> >>
> >> ---
> >>  rtems/config/4.11/rtems-or1k.bset | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/rtems/config/4.11/rtems-or1k.bset
> >> b/rtems/config/4.11/rtems-or1k.bset
> >> index b486885..2e6fb01 100644
> >> --- a/rtems/config/4.11/rtems-or1k.bset
> >> +++ b/rtems/config/4.11/rtems-or1k.bset
> >> @@ -17,7 +17,7 @@
> >>
> >>  #gcc
> >>  %patch add gcc -p1
> >>
> https://raw.githubusercontent.com/heshamelmatary/or1k-rtems/master/patches/gcc-4.8.3-or1k-rtems-29072014.diff
> >> -%hash  md5 gcc-4.8.3-or1k-rtems-29072014.diff
> >> df2555b2dd4de2d78366fabd705f36ac
> >> +%hash  md5 gcc-4.8.3-or1k-rtems-29072014.diff
> >> 97be92fbe69a355625633a8d128fb5f5
> >>
> >>  #gdb
> >>  %patch add gdb -p1
> >>
> https://raw.githubusercontent.com/heshamelmatary/or1k-rtems/master/patches/gdb-7.7-or1k-rtems.diff
> >> --
> >> 2.1.0
> >>
> >>
> >>
> >> ------------------------------
> >>
> >> Subject: Digest Footer
> >>
> >> _______________________________________________
> >> devel mailing list
> >> devel at rtems.org
> >> http://lists.rtems.org/mailman/listinfo/devel
> >>
> >> ------------------------------
> >>
> >> End of devel Digest, Vol 41, Issue 81
> >> *************************************
>
>
>
> --
> Hesham
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20150427/3249d80e/attachment-0002.html>


More information about the devel mailing list