[PATCH] Fix missing include for PTHREAD_MINIMUM_STACK_SIZE

Joel Sherrill joel.sherrill at oarcorp.com
Sun Aug 2 15:34:05 UTC 2015


Top posting.. ada-tests now build on at least 4.11. I committed
the same patch to the master so they should build there. I
didn't run any.

--joel

On 08/02/2015 10:20 AM, Joel Sherrill wrote:
> On 08/01/2015 12:48 PM, Jan Sommer wrote:
>> Am Samstag, 1. August 2015, 12:31:53 schrieb Joel Sherrill:
>>> On 08/01/2015 12:24 PM, Jan Sommer wrote:
>>>> Yes, I needed to add it to make the ada-examples compile.
>>>>
>>> Did it need to be included anywhere other than libgnat/adasupp.c?
>>>
>> Well, so far I haven't encountered the problem somewhere else, but have been working with the Ada-examples mainly atm.
>>
>>> Sebastian reworked public vs private .h files and more includes moved
>>> to .c files. Since everything but Ada specific support files compile
>>> on every target, I am prone to want to fix the file that needs this.
>>>
>> I see. I just saw that pthreadimpl.h defines a call to a function it does not include and thought it might be slipped at some point because it's not used often.
>> I don't mind keeping it local. My goal is to spend less time with the examples in the future anyway ;-)
>>
> I did a test build of 4.11 and master this morning. No patch was
> needed to built libgnat.
>
> But the Ada tests have an init.c which needs some love. Did you
> attempt to build the Ada tests? Just curious before I dive too far
> into fixing ada-tests/support/init.c.
>>> I would check for my patches but I appear to have deleted my RTEMS
>>> clone since then and lost the small patch I had. :(
>>>
>>> --joel
>>>> Am Samstag, 1. August 2015, 12:08:12 schrieb Joel Sherrill:
>>>>> Can you give a configuration or file that broke with this?
>>>>>
>>>>> I recall that I had a local patch that just added this line to an Ada specific C file. Nothing else broke.
>>>>>
>>>>> On August 1, 2015 5:51:31 AM CDT, Jan Sommer<soja-lists at aries.uberspace.de>    wrote:
>>>>>> ---
>>>>>> cpukit/posix/include/rtems/posix/pthreadimpl.h | 1 +
>>>>>> 1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/cpukit/posix/include/rtems/posix/pthreadimpl.h
>>>>>> b/cpukit/posix/include/rtems/posix/pthreadimpl.h
>>>>>> index f95ac9c..33fa33d 100644
>>>>>> --- a/cpukit/posix/include/rtems/posix/pthreadimpl.h
>>>>>> +++ b/cpukit/posix/include/rtems/posix/pthreadimpl.h
>>>>>> @@ -24,6 +24,7 @@
>>>>>> #include<rtems/posix/threadsup.h>
>>>>>> #include<rtems/score/objectimpl.h>
>>>>>> #include<rtems/score/threadimpl.h>
>>>>>> +#include<rtems/score/stackimpl.h>
>>>>>> #include<rtems/score/assert.h>
>>>>>>
>>>>>> #ifdef __cplusplus
>>>>> --joel
>>>
>


-- 
-- Joel Sherrill
Ask me about RTEMS: a free RTOS
Support and Training Available




More information about the devel mailing list