[PATCH] libnetworking/gethostbyht.c: Bugfix for hostf validity test

[Aun-Ali Zaidi]

Hi Gedare,

My patch was a mistake, I tested the conditional '!hostf' and the
reported issue is already fixed in mainline. This patch is pretty much
pointless and the ticket should be fixed. I still can't do that due to
my inability to post to Trac.

For future patches, I will make sure to retain the author and email and
I do understand the copyright implications at stake.

Additionally, I would like to mention that this is not my first time
contributing to open source projects and I have had experiences with
some projects of my own.

Thanks,
Aun-Ali

On 12/14/15 4:57 PM, Gedare Bloom wrote:
> Hi Aun-Ali,
> 
> I see this is the same diff as the one attached to the ticket. In this
> case, you should retain the code's author information by using the
> --author="First Last <email>" in the git-commit command line argument.
> The author of that patch appears to be Tim Cussins
> <timcussins at eml.cc>.
> 
> It is important to keep track of code authorship, as open source
> licenses are protected by copyright law so we need to know who holds
> copyrights. Usually, the copyright holder is the author of code, or
> their employer.
> 
> Thanks,
> Gedare
> 
> On Mon, Dec 14, 2015 at 2:51 PM, Aun-Ali Zaidi <admin at kodeit.net> wrote:
>> closes #1709.
>> ---
>>  cpukit/libnetworking/libc/gethostbyht.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/cpukit/libnetworking/libc/gethostbyht.c b/cpukit/libnetworking/libc/gethostbyht.c
>> index 17723d7..f31bdee 100644
>> --- a/cpukit/libnetworking/libc/gethostbyht.c
>> +++ b/cpukit/libnetworking/libc/gethostbyht.c
>> @@ -223,7 +223,7 @@ struct hostent* gethostent_r(char* buf, int len)
>>    int    curlen;
>>
>>
>> -  if (!hostf) return 0;
>> +  if (hostf<=0) return 0;
>>    fseek(hostf,0,SEEK_END);
>>    curlen=ftell(hostf);
>>    fseek(hostf,0,SEEK_SET);
>> --
>> 2.1.4
>>
>>
>> This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.
>>
>> _______________________________________________
>> devel mailing list
>> devel at rtems.org
>> http://lists.rtems.org/mailman/listinfo/devel

This email and any files transmitted with it are confidential and intended solely for the use of the individual or entity to whom they are addressed. If you have received this email in error please notify the system manager. This message contains confidential information and is intended only for the individual named. If you are not the named addressee you should not disseminate, distribute or copy this e-mail. Please notify the sender immediately by e-mail if you have received this e-mail by mistake and delete this e-mail from your system. If you are not the intended recipient you are notified that disclosing, copying, distributing or taking any action in reliance on the contents of this information is strictly prohibited.