[PATCH] Chase Newlib sys/select.h changes

Nick Withers nick.withers at anu.edu.au
Sun Dec 20 23:45:42 UTC 2015


Hi Sebastian,

Here's an updated patch.

On Tue, 2015-12-15 at 09:13 +0100, Sebastian Huber wrote:
> Hello Nick,
> 
> I checked in the shell changes separately. With them I can build the 
> latest Newlib with --disable-networking. It should be sufficient to 
> remove the <sys/select.h> from libnetworking.

Now that Newlib's reverted the inclusion of sys/select.h in
sys/types.h, it's largely the same as the previous version, minus the
bits you've committed separately.

Would you be able to test with libbsd?

> On 14/12/15 10:09, Sebastian Huber wrote:
> > Hello Nick,
> > 
> > this patch needs an update once this is committed to Newlib:
> > 
> > https://sourceware.org/ml/newlib/2015/msg00905.html
> > 
> > On 10/12/15 10:04, Nick Withers wrote:
> > > Hi all,
> > > 
> > > Attached is a patch for master similar to that I posted to the
> > > Newlib
> > > mailing list in 
> > > https://sourceware.org/ml/newlib/2015/msg00888.html *.
> > > 
> > > It chases Newlib changes to sys/types.h / sys/select.h and allows
> > > us to
> > > use Newlib's sys/select.h directly rather than rolling our own.
> > > 
> > > A few notes:
> > >   - I removed the BSD advertising clause from what's now
> > > sys/selinfo.h,
> > > but am not sure that I should have
> > >   - I made a few not-really-related but minor changes to
> > > cpukit/libmisc/shell/*.c printf()s to ensure format specifiers
> > > matched
> > > parameter types
> > >   - the sys/selinfo.h file doesn't directly correspond to any
> > > FreeBSD
> > > revision, though it's basically the same as 
> > > https://svnweb.freebsd.org/
> > > base/head/sys/sys/selinfo.h?revision=70650&view=markup , not sure
> > > how
> > > fussed we are with e.g., $FreeBSD$ tags and such...?
> > > 
> > > * It doesn't mess with disabling dl tests on PSim; I ran into
> > > troubles
> > > with dl02 which I'll look into separately
-------------- next part --------------
A non-text attachment was scrubbed...
Name: sys_select.v2.patch
Type: text/x-patch
Size: 11877 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/devel/attachments/20151221/17bb4eab/attachment-0002.bin>


More information about the devel mailing list