[PATCH v2] ARM: Add BSP_START_NEEDS_REGISTER_INITIALIZATION

Martin Galvan martin.galvan at tallertechnologies.com
Thu Feb 26 15:39:52 UTC 2015


On Thu, Feb 26, 2015 at 12:03 PM, Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
> On 26/02/15 15:54, Martin Galvan wrote:
>>
>> On Thu, Feb 26, 2015 at 11:47 AM, Sebastian Huber
>> <sebastian.huber at embedded-brains.de>  wrote:
>>>
>>> >Hello Martin,
>>> >
>>> >sorry, I should have look at your bsp-start-init-registers.s earlier.
>>> > This
>>> >stuff looks so generic, that it should go directly into start.S. I guess
>>> > the
>>> >TMS570 will not remain the only ARM core with a lockstep feature.
>>
>> Thanks for the feedback. So that means I should discard the
>> BSP_START_NEEDS_REGISTER_INITIALIZATION symbol altogether and
>> unconditionally call the bsp_start_init_registers routines in
>> arm/shared/start/start.S?
>
>
> No, the define is fine, since we need this code sequence only in certain
> cases.
>
>>
>> I still think the routines themselves should be kept on a separate .S
>> file, though, if only to keep start.S as short and clean as possible.
>>
>
> If you want to keep them in a separate file, then please move the file to
> the shared folder. I don't think this stuff is really BSP specific.

Got it. Will move it to arm/shared and send patch v3. Thanks a lot!

> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>



-- 


Martín Galván

Software Engineer

Taller Technologies Argentina


San Lorenzo 47, 3rd Floor, Office 5

Córdoba, Argentina

Phone: 54 351 4217888 / +54 351 4218211


More information about the devel mailing list