[PATCH] Don't fail to create passwd and group files if /etc already exists

Nick Withers nick.withers at anu.edu.au
Fri Feb 20 09:06:46 UTC 2015


On Fri, 2015-02-20 at 08:59 +0100, Sebastian Huber wrote:
> Hello Nick,
> 
> thanks for the patch. I checked in a slightly different version which 
> ignores the return status completely.

Hi Sebastian,

Your commit effectively reverts Joel's changes in
https://git.rtems.org/rtems/commit/?id=3211e8e9c0565fae8b13ba0115e3a23ad3ae8ade

Would chucking a (void) in front of the mkdir() shut Coverity up?
-- 
Nick Withers

Embedded Systems Programmer
Department of Nuclear Physics, Research School of Physics and Engineering
The Australian National University (CRICOS: 00120C)

> On 20/02/15 05:13, Nick Withers wrote:
> > Hi all,
> >
> > Commit 3211e8e9c0565fae8b13ba0115e3a23ad3ae8ade added error checking to
> > a mkdir("/etc", ...) call in pwdgrp_init().
> >
> > That call might fail if the directory already exists. In my case,
> > because I'm tarfs-ing stuff into /etc before invoking the NFS client,
> > which calls pwdgrp_init().
> >
> > The attached patch allows the mkdir() call to fail with EEXIST.
> >
> > Cheers!
> >
> >
> > _______________________________________________
> > devel mailing list
> > devel at rtems.org
> > http://lists.rtems.org/mailman/listinfo/devel
> 





More information about the devel mailing list