[PATCH 2/2] bsp/tms570 Use bitfields instead of hard-coded values
Joel Sherrill
joel.sherrill at oarcorp.com
Fri Jul 17 17:37:46 UTC 2015
On July 17, 2015 12:22:14 PM CDT, Pavel Pisa <pisa at cmp.felk.cvut.cz> wrote:
>Hello Joel,
>
>I have been with Premek when he tested these on the target.
>
>[PATCH 1/2] bsp/tms570: skipped 32bit field definitions and corrected
>single bit fields
> This one clean header files. There has been unnecessary defines
> of whole registers as fields and mistake in single bit definitions.
> I am not happy that this slipped, we have discused and planned use
> of BSP_BIT32 long time ago but we have found mistake during attempt
> to clean BSP a little more and get rid of hardcoded values.
>
> Patch is huge so it blocks on list moderator approval.
> If you do not have it received then I or Premek send it offlist
> gzipped.
>
Please cc Gedare if you need to send it privately. I wasn't concerned about the quality of the patch. Only that I was leaving the office and will be in the UK next week so wasn't in a position to apply it. :)
So whoever can apply it can.
>
>[PATCH 2/2] bsp/tms570 Use bitfields instead of hard-coded values
> This makes already implemented code much more readable.
>
>If these patches can make to common base it would be nice.
>
>Best wishes,
>
> Pavel
--joel
More information about the devel
mailing list