[PATCH 3/8] score: Add potpourri lock statistics

Sebastian Huber sebastian.huber at embedded-brains.de
Sat Jul 25 09:46:07 UTC 2015


----- Gedare Bloom <gedare at gwu.edu> schrieb:
> All of the external lock objects will re-use the same lock statistics
> struct? Is there any reason to separate the stats more? At least in
> terms of the locks provided in RTEMS, you could create an array of the
> Potpourri_stats and assign the known usages into the array, with a
> catch-all at offset zero for the unknown usages. I don't know if this
> makes sense or not, but in terms of understanding the lock stats this
> might be a good thing for profiling purposes rather than aggregrating
> all stats into the same struct?

You have one set of stats per thread for all the external thread queues.  A global stats object is not that good due to the resulting cache traffic and you would need a lock itself to protect these stats.  You have to take nested locks into account as well.  I wouldn't change the existing SMP lock stats profiling in RTEMS, since this is very valuable to figure out the hot spots in the system and optimize efficiently.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.



More information about the devel mailing list