[rtems-libbsd commit] Add error() to the BSD program support.

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Jun 18 07:54:13 UTC 2015



On 18/06/15 03:26, Chris Johns wrote:
>>> >>diff --git a/rtemsbsd/include/machine/rtems-bsd-program.h
>>> >>b/rtemsbsd/include/machine/rtems-bsd-program.h
>>> >>index b2e542e..7c2837e 100644
>>> >>--- a/rtemsbsd/include/machine/rtems-bsd-program.h
>>> >>+++ b/rtemsbsd/include/machine/rtems-bsd-program.h
>>> >>@@ -56,6 +56,9 @@ rtems_bsd_program_call_main(const char *name, int
>>> >>(*main)(int, char **),
>>> >>   void
>>> >>   rtems_bsd_program_exit(int exit_code) __dead2;
>>> >>   +void
>>> >>+rtems_bsd_program_error(const char *, ...) __attribute__ ((__format__
>>> >>(__printf__, 1, 2)));
>>> >>+
>>> >>   const char *
>>> >>   rtems_bsd_program_get_name(void);
>>> >>   @@ -69,14 +72,22 @@ void
>>> >>   rtems_bsd_program_unlock(void);
>>> >>     #ifndef RTEMS_BSD_PROGRAM_NO_EXIT_WRAP
>>> >>+  #undef exit
>> >
>> >What is the reason for this #undef?
>> >
> I got warnings for printf in tcpdump for some reason so add the undef to
> all symbols present.
>
> Does it hurt having it present ?
>

Yes, since in this case we don't get the redefine warning in general. 
This redefine might be ok in your special case, but in general it is not 
right to say in one place A -> B and in another A -> C. You can use the 
#undef before you include the rtems-bsd-program.h file.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list