Fwd: [PATCH 000/111] GRLIB/LEON RTEMS RCC patches

[Daniel Hellstrom]

On 03/15/2015 10:29 PM, Chris Johns wrote:
> On 14/03/2015 12:39 pm, Amar Takhar wrote:
>>> On 11/03/2015 1:27 am, Karel Gardas wrote:
>>>> Yes, this is a big patch but if you do not merge it now and later
>>>> following waf work you do tree/file placement refactoring than the patch
>>>> would be even harder to merge.
>>
>> I was thinking this would land in 4.12 then waf would be based off of that.
>> 4.12 would be released weeks after 4.11.1
>>
>> There needs to be another branch for any 'bigger' changes to hit RTEMS after
>> 4.11.
>>
>
> Sure.
>
>>
>> On 2015-03-14 11:25 +1100, Chris Johns wrote:
>>>
>>> Yes I tend to see this as important. It will be less overall work to
>>> merge before the source is changed.
>>>
>>> My support for merging sooner rather than latter is conditional on
>>> Daniel and team ensuring the SPARC and LEON BSP are tested and there are
>>> no regressions for 4.11.
>>
>> As long as it's well tested and we redo all the testing Joel has already done..
>>
>
> There are no tests in the patch set which is a key concern.

Thank you all for you interest and concerns about this.

I agree with you that it is a problem that there are no tests. As I see it the new drivers adds functionality and are well isolated from the other code. The existing drivers being patched never had 
tests and continue not to have tests, I'm not sure I've seen driver tests for other BSPs? The drivers comes from RCC based on RTEMS-4.10.2 which includes many fixes on the existing drivers and are 
being used in many hardware set ups. When it comes to the libdrvmgr and libpci it will be SPARC only at least. The minimum mandatory drivers for RTEMS are IRQCtrl, Timer and Console drivers. The IRQ 
Ctrl driver is not affected by drvmgr or libpci. The main concern would therefore be the Timer driver and Console driver, which is tested by the RTEMS tests which seems to execute successfully.

DanielH