I think there is a mistake in some bsp_specs files

Joel Sherrill joel.sherrill at oarcorp.com
Wed May 13 23:59:50 UTC 2015



On May 13, 2015 6:57:29 PM CDT, Chris Johns <chrisj at rtems.org> wrote:
>On 14/05/2015 3:10 am, Joel Sherrill wrote:
>> 
>> 
>> On 5/13/2015 4:07 AM, Tom wrote:
>>> Hi all
>>>  
>>> I read the bsp_specs files contained in some bsps, which reside in 
>>> libbsp/arm, libbsp/bfin and libbsp/m32r
>>>  
>>> *endfile:
>>> %{!qrtems: *(old_endfiles)} %{qrtems: crtend.o%s crtn.o%s }
>>>                     ^
>>> I think it should be %.
>>>  
>>> I wrote a specs file and tested using gcc 4.8.2. 
>>>  
>>>
>> This definitely looks like a typo that we are lucky appears
>> to have no impact. The only time the bsp_spec is used, the other
>> path (-qrtems) is tripped.
>> 
>> Is there objection to me fixing this in the following files:
>>
>
>No. Please raise a ticket to track the change.

If there is a ticket can it be done before branching? I would have filed the ticket.

>Thanks.
>Chris

--joel



More information about the devel mailing list