[PATCH] LPC1768: Fix compilation error

André Marques andre.lousa.marques at gmail.com
Fri Nov 6 22:57:00 UTC 2015


Hello,

This issue was resolved earlier with the following patch

https://git.rtems.org/rtems/commit/c/src/lib/libbsp/Makefile.am?id=a57b72ded94b4e77fd4f9bd3cc37380a02e3e35a

where the inclusion of the GPIO API header file was removed from the 
libbsp/shared makefile and moved (in the case of the Raspberry Pi, but I 
forgot about the beagle BSP) to the BSP makefile which intends to use 
the API. This avoids these name clashes with BSPs that already have a 
gpio.h header file.

However the following patch reintroduced the gpio API header on the 
libbsp/shared makefile

https://git.rtems.org/rtems/commit/c/src/lib/libbsp/Makefile.am?id=6f6e5d758f6a1e7dcae74e151c3dd3d1034da232

This last patch should be reverted, and the shared/include/gpio.h should 
be included in the beagle BSP makefile that requires it, and motivated 
this reintroduction.

I think it is better to have the BSPs include the gpio API header file 
if they actually implement the API, than forcing the header to all BSPs 
and creating these problems.


Às 14:29 de 05-11-2015, Sebastian Huber escreveu:
> On 05/11/15 15:17, Martin Galvan wrote:
>> The LPC1768 variants have a gpio.h file whose name clashes with the 
>> gpio.h from
>> the new GPIO API. This results on the BSPs failing to compile.
>>
>> This patch renames the LPC1768 gpio.* files to lpc-gpio.*, as it's 
>> done on other
>> BSPs (e.g. Beaglebone).
>>
>> Closes #2441.
>
> Thanks.
>

--André Marques.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20151106/ef13ef52/attachment-0002.html>


More information about the devel mailing list