[PATCH-V2 1/1] sparc: Fix context switch on SMP
Sebastian Huber
sebastian.huber at embedded-brains.de
Mon Nov 16 10:27:19 UTC 2015
On 16/11/15 11:06, Daniel Cederman wrote:
> @@ -202,6 +193,13 @@ try_update_is_executing:
> ! The next load is in a delay slot, which is all right
> #endif
>
> + ld [%o1 + PSR_OFFSET], %g1 ! g1 = heir psr
> + andn %g1, SPARC_PSR_CWP_MASK, %g1 ! g1 = heir psr w/o cwp
> + or %g1, %g3, %g1 ! g1 = heir psr with cwp
> + or %g1, SPARC_PSR_ET_MASK, %g1 ! g1 = heir psr traps enabled
Do we really need the "or %g1, SPARC_PSR_ET_MASK, %g1"? I think we
should simply use the value of the saved PSR and omit this step.
> + mov %g1, %psr ! restore status register and
> + ! **** ENABLE TRAPS ****
> +
> ld [%o1 + G5_OFFSET], %g5 ! restore the global registers
> ld [%o1 + G7_OFFSET], %g7
--
Sebastian Huber, embedded brains GmbH
Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone : +49 89 189 47 41-16
Fax : +49 89 189 47 41-09
E-Mail : sebastian.huber at embedded-brains.de
PGP : Public key available on request.
Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
More information about the devel
mailing list