[PATCH] including string.h is not needed
Zhu Zhongjie
zhongjiezhu at yahoo.com
Tue Apr 12 10:34:27 UTC 2016
On Friday, March 25, 2016 9:50 PM, Joel Sherrill <joel at rtems.org> wrote:
I was going to commit this but no longer have the original patch in my mailbox.
It looks screwed up in the mail archives.
If either of you send it to me, I will commit it.
--joel
On Fri, Mar 25, 2016 at 8:25 AM, Gedare Bloom <gedare at rtems.org> wrote:
This looks fine to me if someone cares to commit it.
On Wed, Feb 17, 2016 at 5:05 AM, Zhu Zhongjie <zhongjiezhu at yahoo.com> wrote:
>
> ---
> cpukit/libcsupport/src/assoclocalbyname.c | 2 --
> cpukit/libcsupport/src/assoclocalbyremote.c | 2 --
> cpukit/libcsupport/src/assoclocalbyremotebitfield.c | 3 ---
> cpukit/libcsupport/src/assocnamebad.c | 1 -
> cpukit/libcsupport/src/assocnamebylocal.c | 2 --
> cpukit/libcsupport/src/assocnamebyremote.c | 2 --
> cpukit/libcsupport/src/assocptrbylocal.c | 2 --
> cpukit/libcsupport/src/assocptrbyremote.c | 2 --
> cpukit/libcsupport/src/assocremotebylocal.c | 2 --
> cpukit/libcsupport/src/assocremotebylocalbitfield.c | 3 ---
> cpukit/libcsupport/src/assocremotebyname.c | 2 --
> 11 files changed, 23 deletions(-)
>
> diff --git a/cpukit/libcsupport/src/assoclocalbyname.c
> b/cpukit/libcsupport/src/assoclocalbyname.c
> index 3904500..2be2f65 100644
> --- a/cpukit/libcsupport/src/assoclocalbyname.c
> +++ b/cpukit/libcsupport/src/assoclocalbyname.c
> @@ -23,8 +23,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> uint32_t rtems_assoc_local_by_name(
> const rtems_assoc_t *ap,
> const char *name
> diff --git a/cpukit/libcsupport/src/assoclocalbyremote.c
> b/cpukit/libcsupport/src/assoclocalbyremote.c
> index 24a86d8..0d06118 100644
> --- a/cpukit/libcsupport/src/assoclocalbyremote.c
> +++ b/cpukit/libcsupport/src/assoclocalbyremote.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> uint32_t rtems_assoc_local_by_remote(
> const rtems_assoc_t *ap,
> uint32_t remote_value
> diff --git a/cpukit/libcsupport/src/assoclocalbyremotebitfield.c
> b/cpukit/libcsupport/src/assoclocalbyremotebitfield.c
> index 23b4c72..8fe24cb 100644
> --- a/cpukit/libcsupport/src/assoclocalbyremotebitfield.c
> +++ b/cpukit/libcsupport/src/assoclocalbyremotebitfield.c
> @@ -12,9 +12,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> -
> uint32_t rtems_assoc_local_by_remote_bitfield(
> const rtems_assoc_t *ap,
> uint32_t remote_value
> diff --git a/cpukit/libcsupport/src/assocnamebad.c
> b/cpukit/libcsupport/src/assocnamebad.c
> index 3369141..f3084d5 100644
> --- a/cpukit/libcsupport/src/assocnamebad.c
> +++ b/cpukit/libcsupport/src/assocnamebad.c
> @@ -14,7 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <inttypes.h>
> #include <stdio.h> /* sprintf */
>
> const char *
> diff --git a/cpukit/libcsupport/src/assocnamebylocal.c
> b/cpukit/libcsupport/src/assocnamebylocal.c
> index 0dd47b8..1f752a1 100644
> --- a/cpukit/libcsupport/src/assocnamebylocal.c
> +++ b/cpukit/libcsupport/src/assocnamebylocal.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> const char *rtems_assoc_name_by_local(
> const rtems_assoc_t *ap,
> uint32_t local_value
> diff --git a/cpukit/libcsupport/src/assocnamebyremote.c
> b/cpukit/libcsupport/src/assocnamebyremote.c
> index 376ba47..70c6c38 100644
> --- a/cpukit/libcsupport/src/assocnamebyremote.c
> +++ b/cpukit/libcsupport/src/assocnamebyremote.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
>
> const char *rtems_assoc_name_by_remote(
> const rtems_assoc_t *ap,
> diff --git a/cpukit/libcsupport/src/assocptrbylocal.c
> b/cpukit/libcsupport/src/assocptrbylocal.c
> index a0e7c3c..bacc3db 100644
> --- a/cpukit/libcsupport/src/assocptrbylocal.c
> +++ b/cpukit/libcsupport/src/assocptrbylocal.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> const rtems_assoc_t *rtems_assoc_ptr_by_local(
> const rtems_assoc_t *ap,
> uint32_t local_value
> diff --git a/cpukit/libcsupport/src/assocptrbyremote.c
> b/cpukit/libcsupport/src/assocptrbyremote.c
> index 4651581..efb6356 100644
> --- a/cpukit/libcsupport/src/assocptrbyremote.c
> +++ b/cpukit/libcsupport/src/assocptrbyremote.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> const rtems_assoc_t *rtems_assoc_ptr_by_remote(
> const rtems_assoc_t *ap,
> uint32_t remote_value
> diff --git a/cpukit/libcsupport/src/assocremotebylocal.c
> b/cpukit/libcsupport/src/assocremotebylocal.c
> index cd5fa0c..2f8d384 100644
> --- a/cpukit/libcsupport/src/assocremotebylocal.c
> +++ b/cpukit/libcsupport/src/assocremotebylocal.c
> @@ -12,8 +12,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> uint32_t rtems_assoc_remote_by_local(
> const rtems_assoc_t *ap,
> uint32_t local_value
> diff --git a/cpukit/libcsupport/src/assocremotebylocalbitfield.c
> b/cpukit/libcsupport/src/assocremotebylocalbitfield.c
> index b26c98c..4da16bd 100644
> --- a/cpukit/libcsupport/src/assocremotebylocalbitfield.c
> +++ b/cpukit/libcsupport/src/assocremotebylocalbitfield.c
> @@ -23,9 +23,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> -
> uint32_t rtems_assoc_remote_by_local_bitfield(
> const rtems_assoc_t *ap,
> uint32_t local_value
> diff --git a/cpukit/libcsupport/src/assocremotebyname.c
> b/cpukit/libcsupport/src/assocremotebyname.c
> index 8a894fc..bd9c2ba 100644
> --- a/cpukit/libcsupport/src/assocremotebyname.c
> +++ b/cpukit/libcsupport/src/assocremotebyname.c
> @@ -14,8 +14,6 @@
> #include <rtems.h>
> #include <rtems/assoc.h>
>
> -#include <string.h> /* strcat, strcmp */
> -
> uint32_t rtems_assoc_remote_by_name(
> const rtems_assoc_t *ap,
> const char *name
> --
> 1.9.1
>
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
_______________________________________________
devel mailing list
devel at rtems.org
http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160412/0a9ae0df/attachment-0001.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-remove-string.h.patch
Type: text/x-patch
Size: 5443 bytes
Desc: not available
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160412/0a9ae0df/attachment-0001.bin>
More information about the devel
mailing list