[PATCH 2/3] i386/pc386: Add IO and memory support to PCI UART devices.

Chris Johns chrisj at rtems.org
Wed Apr 20 23:47:12 UTC 2016


On 21/04/2016 8:57 AM, Joel Sherrill wrote:
> 
>     +/*
>     + *  IO Register Access Routines
>     + */
>     +static uint8_t pci_ns16550_io_get_register(uint32_t addr, uint8_t i)
>     +{
>     +  uint8_t val = rtems_inb(addr + i);
>     +  if (UART_PCI_IO)
>     +    printk( "RD(%p -> 0x%02x) ", addr + i, val );
>     +  return val;
>     +}
>     +
>     +static void pci_ns16550_io_set_register(uint32_t addr, uint8_t i,
>     uint8_t val)
>     +{
>     +  if (UART_PCI_IO)
>     +    printk( "WR(%p <- 0x%02x) ", addr + i, val );
>     +  rtems_outb(addr + i, val);
>     +}
>     +
> 
> 
> Is it possible to use the same com access ports that are used for com1-com4?
> Or at least move to shared ones?

It could be done if want.

> 
> They are in conscfg.c. It would be good if we could eliminate some code
> during this. :)
>  

I have not looked at the differences between the old driver and the new
one Sebastian created. We need to move to that driver for SMP support.
Maybe this all gets cleaned up then?

Chris


More information about the devel mailing list