[PATCH 02/12] score: Add ticks per second to configuration

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Apr 8 08:30:16 UTC 2016



On 08/04/16 10:07, Chris Johns wrote:
> On 8/04/2016 5:35 PM, Sebastian Huber wrote:
>> On 08/04/16 09:06, Chris Johns wrote:
>>> I assume the microsecond, nanosecond and tick per sec values all need
>>> to agree.
>>>
>>> Does anything check this is the case and raise a fatal error if they
>>> do not?
>>
>> Currently nobody checks this. Should we check this via an _Assert()? If
>> we add new fatal errors, it will get difficult. We need to test it.
>
> Yes an assert is perfect. It is a hard config error.

The _Assert() is only active in case you use RTEMS_DEBUG.

>
>> The
>> Configuration is read-only. We would have to avoid <rtems/confdefs.h> to
>> create a corrupt Configuration and this is very bad.
>
> It is not recommended anyone manually create their own Configuration 
> table but there is nothing that says you _have_ to use confdefs.h. I 
> do remember the pre-confdefs days.
>
> If we create a dependence we should ensure things are within spec 
> before continuing.

I don't think its feasible to avoid <rtems/confdefs.h>. Its now the only 
way to create a configuration.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list