[PATCH] dev: Add NXP SC16IS752 serial device driver

[Sebastian Huber]

On 14/12/16 22:59, Chris Johns wrote:
> On 15/12/2016 01:23, Sebastian Huber wrote:
>> From: Alexander Krutwig <alexander.krutwig at embedded-brains.de>
>>
>> Update #2841.
>> ---
>>   cpukit/dev/Makefile.am                        |   7 +
>>   cpukit/dev/include/dev/serial/nxp-sc16is752.h | 165 +++++++++++++++++
>>   cpukit/dev/preinstall.am                      |   9 +
>>   cpukit/dev/serial/nxp-sc16is752-regs.h        | 108 +++++++++++
>>   cpukit/dev/serial/nxp-sc16is752-spi.c         | 126 +++++++++++++
>>   cpukit/dev/serial/nxp-sc16is752.c             | 257 
>> ++++++++++++++++++++++++++
>>   6 files changed, 672 insertions(+)
>>   create mode 100644 cpukit/dev/include/dev/serial/nxp-sc16is752.h
>>   create mode 100644 cpukit/dev/serial/nxp-sc16is752-regs.h
>>   create mode 100644 cpukit/dev/serial/nxp-sc16is752-spi.c
>>   create mode 100644 cpukit/dev/serial/nxp-sc16is752.c
>
> I see this change adds serial drivers to the cpukit/dev tree.

Yes, and it was in total more than one man month of work to make this 
possible. Its not a small thing.

>
> Is this where all new serial drivers are to be located? I am happy to 
> see this happen but we need suitable documentation about this and any 
> rules etc developers need to know including "add all new serial 
> drivers here".

The preferred place for drivers should be the cpukit. We need however a 
suitable abstraction of the low-level hardware access. We don't have 
this at the moment except for I2C and SPI.

>
> Do we have documentation about the cpukit/dev tree?

Documentation of the new SPI and I2C frameworks is on my todo list. I 
will add some notes to the console driver chapter.

>
> What happens to the existing drivers we have in libchip and other 
> locations? Is the aim to have all driver move to cpukit/dev?

Yes, this should be the aim, however, I don't see that anyone has time 
to do this. I already spend more than one man week in vain to do this 
and eventually gave up.

>
> For the record I support the cpukit/dev driver tree and think libchip 
> should be removed.
>
> Chris
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.