[PATCH 6/6] OR1k cache invalidate additions
jakob.viketoft at aacmicrotec.com
Sat Feb 20 20:28:40 UTC 2016
From: devel [devel-bounces at rtems.org] on behalf of Gedare Bloom [gedare at rtems.org]
Sent: Saturday, February 20, 2016 14:35
To: jakob.viketoft at gmail.com
Cc: rtems-devel at rtems.org
Subject: Re: [PATCH 6/6] OR1k cache invalidate additions
>On Sat, Feb 20, 2016 at 3:34 AM, <jakob.viketoft at gmail.com> wrote:
>> From: Jakob Viketoft <jakob.viketoft at aacmicrotec.com>
>When breaking lines in expressions, leave the first and last line empty,
> addr = ...();
> addr > 0;
> addr -= ...
Didn't see that. Will fix.
>> + _CPU_OR1K_Cache_data_block_flush((void*) addr);
>Casting int to void* is not a great idea. Consider using uintptr_t instead.
Oh, there was a number of other void-casts already there, so I didn't react to this. I'll take a look at those too, then.
Senior Engineer in RTL and embedded software
ÅAC Microtec AB
Dag Hammarskjölds väg 48
SE-751 83 Uppsala, Sweden
T: +46 702 80 95 97
More information about the devel