[PATCH 1/6] Patches for the OR1k CPU handling and definitions

Gedare Bloom gedare at rtems.org
Sat Feb 20 13:23:32 UTC 2016


Hi Jakob,

I should have mentioned yesterday that you ought to open one or more
tickets on our Trac (devel.rtems.org) and then reference those tickets
in your commit messages using e.g. "updates #xxxx" or "fixes #nnnn".

Also, if your test cases are suitably generic and useful, you might
consider providing them as separate contributions to improve RTEMS
test suite.

> diff --git a/cpukit/score/cpu/or1k/rtems/score/cpu.h b/cpukit/score/cpu/or1k/rtems/score/cpu.h
> index 7364343..740bdda 100644
> --- a/cpukit/score/cpu/or1k/rtems/score/cpu.h
> +++ b/cpukit/score/cpu/or1k/rtems/score/cpu.h
...
> @@ -385,6 +574,17 @@ static inline void _OR1K_Sync_pipeline( void )
>  #define _OR1KSIM_CPU_Halt() \
>         asm volatile ("l.nop 0xc")
>
> +static inline uint32_t _OR1K_Find_First_One(uint32_t value)
Probably should be using _OR1K_Find_first_one() -- see also
https://devel.rtems.org/wiki/Developer/Coding/NamingRules



More information about the devel mailing list