[PATCH v3 2/2] Subject: Update PWM driver imported from BBBIO

Ben Gras beng at shrike-systems.com
Sat Jul 2 13:54:50 UTC 2016


On Fri, Jul 1, 2016 at 11:12 PM, Martin Galvan
<martin.galvan at tallertechnologies.com> wrote:
> Hi Punit, thanks for the patch. As we spoke in the group chat with the other mentors, this seems to
> be good for a first version. I'll be pointing out the required changes for the next version, but
> unless somebody sees anything blocking this should be good to merge.

I agree!


> +
> +/* Currently these definitions are for BeagleBone Black board only
> + * Later on Beagle-xM board support can be added in this code.
> + * After support gets added if condition should be removed
> If you're referring to IS_AM335X/IS_DM3730, from what I've seen there are always two
> versions of the code, one for each SoC. So I don't think this #if will be removed,
> even after support is added for DM3730. Maybe Ben/Ketul know a bit more about this than
> I do, though.

You're right, depending on how different the hardware is. It could be
(I haven't checked) that the hardware works the same but the base
address is different, such as with the UARTs.
In that case we can re-use this code and the differences will be
smaller. So I think here
simply removing "After support gets added if condition should be
removed" should be OK, although I don't consider it blocking for

More information about the devel mailing list