Code review for Raspberry Pi USB driver

[Deval Shah]

Hello all,

I have successfully ported the bcm283x_dwcotg driver for the Raspberry Pi.
Changes are shown in the commit >
https://github.com/deval-maker/rtems-libbsd/commit/fd650f7ded413a0d891b5395abb0c8768d71acc7.
I need feedback on the code.

Also am getting error in mailbox functions (failed to set power state,
err=-2). As far as I know Pavel and Mudit are looking into this problem. I
can not move to next part before solving this issue. Please let me know how
can I contribute if the problem is not already solved.

I am pasting the log for init01 test from rtems-libbsd which I ran on
Raspberry Pi Model 1/B+.

*** LIBBSD INIT 1 TEST ***

nexus0: <RTEMS Nexus device>

bcm283x_dwcotg0: <DWC OTG 2.0 integrated USB controller (bcm283x)> on nexus0
bcm283x_dwcotg0: failed to set power state, err=-2
usbus0 on bcm283x_dwcotg0
usbus0: 480Mbps High Speed USB v2.0
uhub0: <DWCOTG OTG Root HUB, class 9/0, rev 2.00/1.00, addr 1> on usbus0
Sleeping to see what happens
uhub0: 1 port with 1 removable, self powered
Stack usage by thread
    ID      NAME    LOW          HIGH     CURRENT     AVAILABLE     USED
0x09010001  IDLE 0x12eae0 - 0x12fadf 0x12fa78      4080        128
0x0a010001  UI1  0x12fcf8 - 0x137cf7 0x137920     32752       1008
0x0a010002  TIME 0x138448 - 0x140447 0x140388     32752        332
0x0a010003  IRQS 0x140450 - 0x14844f 0x148390     32752        308
0x0a010004  _BSD 0x15ac98 - 0x162c97 0x162bd0     32752        336
0x0a010005  _BSD 0x162df0 - 0x16adef 0x16ad28     32752        240
0x0a010006  _BSD 0x16d3c8 - 0x1753c7 0x175300     32752        240
0x0a010007  _BSD 0x175568 - 0x17d567 0x17d4a0     32752        240
0x0a010008  _BSD 0x17d628 - 0x185627 0x185568     32752        232
0x0a010009  _BSD 0x1856e8 - 0x18d6e7 0x18d628     32752        232
0x0a01000a  _BSD 0x18e908 - 0x196907 0x196848     32752        232
0x0a01000b  _BSD 0x196970 - 0x19e96f 0x19e8b0     32752        232
0x0a01000c  _BSD 0x19e9d8 - 0x1a69d7 0x1a6918     32752        232
0x0a01000d  _BSD 0x1a6a40 - 0x1aea3f 0x1ae980     32752        880
0x0a01000e  _BSD 0x1aeaa8 - 0x1b6aa7 0x1b69e8     32752        232
*** END OF TEST LIBBSD INIT 1 ***


Thank you,
Deval Shah
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20160624/7b506463/attachment-0001.html>