[PATCH] Adding functionalities to Mailbox RPi

Pavel Pisa ppisa4lists at pikron.com
Tue Jun 28 15:18:12 UTC 2016

Hello Mudit and others,

On Monday 27 of June 2016 15:09:39 Mudit Jain wrote:
> Hi,
> Any consensus regarding the issue ?
> Do we go forward with the present implementation or a change is required ?

I have pushed your patch to move development forward.
I have run RTEMS uncrustify on VideoCore sources
per Gedare's request after commiting

  uncrustify --backup -c /home/pi/repo/rtems/git/rtems.uncrustify vc.h

I have reverted some changes which really impair readability.
Then I have silenced some build warnings, most caused by changes
of RTEMS printk requiring rtems/bspIo.h include.

Please, rebase your changes onto updated mainline
and try to follow suggested sources formating.

As for DMA/VideoCore mailbox access fixes, you can work with
actual solution. I expect that appropriate functions would
be used as cache manager issue for RPi and some other
ARM machines is resolved. But it would not influence
your code if you use bcm2835_mailbox_buffer_flush_and_invalidate.

There are more critical consequences for drivers using DMA.
If they use directly CP15 ARM specific functions, then they are
OK. If they are written portable then without some for fixes
they are broken now. You can use my patch but I expect that
it should be changed/extended.

Best wishes,


More information about the devel mailing list