[PATCH 5/7] Adding RTEMS support for FREEBSD TTY

[Kirspel, Kevin]

I will revert the PPP changes.  It will still uses RTEMS termios instead of FREEBSD.

Kevin Kirspel
Electrical Engineer - Sr. Staff
Idexx Roswell
235 Hembree Park Drive
Roswell GA 30076
Tel: (770)-510-4444 ext. 81642
Direct: (770)-688-1642
Fax: (770)-510-4445

-----Original Message-----
From: Sebastian Huber [mailto:sebastian.huber at embedded-brains.de] 
Sent: Friday, April 07, 2017 5:12 AM
To: Kirspel, Kevin <Kevin-Kirspel at idexx.com>; devel at rtems.org
Subject: Re: [PATCH 5/7] Adding RTEMS support for FREEBSD TTY

On 06/04/17 03:11, Kevin Kirspel wrote:
> ---
>   rtemsbsd/include/machine/rtems-bsd-commands.h     |   2 +
>   rtemsbsd/include/machine/rtems-bsd-kernel-space.h |   1 +
>   rtemsbsd/include/rtems/bsd/local/opt_gdb.h        |   1 +
>   rtemsbsd/include/rtems/netcmds-config.h           |   2 +
>   rtemsbsd/rtems/rtems-bsd-shell-stty.c             |  40 +++++++
>   rtemsbsd/sys/fs/devfs/devfs_devs.c                |  86 +++++++++++++-
>   rtemsbsd/sys/fs/devfs/devfs_vnops.c               | 136 ++++++++++++++++++++++
>   rtemsbsd/sys/net/ppp_tty.c                        |  10 +-
>   8 files changed, 263 insertions(+), 15 deletions(-)
>   create mode 100644 rtemsbsd/include/rtems/bsd/local/opt_gdb.h
>   create mode 100644 rtemsbsd/rtems/rtems-bsd-shell-stty.c
>   mode change 100755 => 100644 rtemsbsd/sys/fs/devfs/devfs_devs.c
>   create mode 100644 rtemsbsd/sys/fs/devfs/devfs_vnops.c
[...]

> diff --git a/rtemsbsd/sys/fs/devfs/devfs_vnops.c 
> b/rtemsbsd/sys/fs/devfs/devfs_vnops.c
> new file mode 100644
> index 0000000..8c4a786
> --- /dev/null
> +++ b/rtemsbsd/sys/fs/devfs/devfs_vnops.c
> @@ -0,0 +1,136 @@
> +/*
> + * Copyright (c) 2016 embedded brains GmbH.  All rights reserved.
> + *
> + *  embedded brains GmbH
> + *  Dornierstr. 4
> + *  82178 Puchheim
> + *  Germany
> + *  <rtems at embedded-brains.de>

This should probably be your copyright (please check other files too).

> diff --git a/rtemsbsd/sys/net/ppp_tty.c b/rtemsbsd/sys/net/ppp_tty.c 
> index 9d416ea..718b146 100644
> --- a/rtemsbsd/sys/net/ppp_tty.c
> +++ b/rtemsbsd/sys/net/ppp_tty.c
> @@ -426,16 +426,8 @@ ppptioctl(struct rtems_termios_tty *tty, rtems_libio_ioctl_args_t *args)
>       struct ppp_softc   *sc    = tty->t_sc;
>   
>       switch (cmd) {
> -    case RTEMS_IO_RCVWAKEUP:
>       case RTEMS_IO_SNDWAKEUP:
> -    case TIOCDRAIN:
> -    case TIOCFLUSH:
> -    case TIOCGETA:
> -    case TIOCGETD:
> -    case TIOCSETA:
> -    case TIOCSETAF:
> -    case TIOCSETAW:
> -    case TIOCSETD:
> +    case RTEMS_IO_RCVWAKEUP:
>           error = rtems_termios_ioctl(args);
>   	break;
>   

Are you sure of this change? The PPP driver is a standard Termios driver ported from the old network stack. It would be nice to get rid of it eventually.

--
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.