[PATCH 04/11] Changes inttype used and adds casts, fixes 6 format warnings

Joel Sherrill joel at rtems.org
Fri Apr 7 23:05:26 UTC 2017

On Fri, Apr 7, 2017 at 5:50 PM, Cillian O'Donnell <cpodonnell8 at gmail.com>

> It's a duplicate, that still has warnings. I couldn't figure out how to
> get rid of it. I'm new to git.
This might be one where PRItime_t needs to be defined in rtems/inttypes.h
and that
used. I think that's the type returned.

Also you should be working on a git branch and be able to do something like
"git rebase -i master" and follow the instructions to delete a single patch.

Before sending again:

+ Check all against my few comments
+ fix the short message so it is something like
"rtems/src/ratemonreportstatistics.c: Use inttypes.h constants to remove N

That type of message makes it easier to spot what changed in the git web
Use a it of judgement to shorten the filename. Often "BSP/XXX/YYY.c:
is enough to point someone to the file.

The patches generally look good. Mastering printf() is a challenge. It is
and doing the format strings so they are portably warning free is tricky.

Heading home now. I should already be there. :)


> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20170407/d8c7c736/attachment-0002.html>

More information about the devel mailing list