[rtems commit] genmcf548x/irq/irq.c: Fix incompatible pointer warning

Joel Sherrill joel at rtems.org
Wed Apr 26 01:01:17 UTC 2017


On Tue, Apr 25, 2017 at 7:22 PM, Chris Johns <chrisj at rtems.org> wrote:

> On 26/04/2017 10:19, Gedare Bloom wrote:
>
>>  static void_func get_exception_handler(rtems_vector_number vector)
>>>  {
>>> +  void **vbr;
>>>    void_func *exception_table;
>>>
>>> -  m68k_get_vbr(exception_table);
>>> +  m68k_get_vbr(vbr);
>>> +
>>> +  exception_table = (void_func *)vbr;
>>>
>>> This looks strange. Can you achieve a similar effect with
>> m68k_get_vbr( (void*)exception_table );
>>
>>
> I think so. I prefer this.


On this architectural variant, m68k_get_vbr() is a macro with an assignment.
This results in the LHS having a cast to get the destination which we had
to work through the code base removing during the gcc 3.4 days.

I tried it and it didn't work. YMMV

--joel


>
>
> Chris
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20170425/ca72f061/attachment-0002.html>


More information about the devel mailing list