[PATCH 8/9] covoar/CoverageReaderQEMU.cc: Remove trace block matching check.

Cillian O'Donnell cpodonnell8 at gmail.com
Fri Aug 25 21:53:31 UTC 2017


This removes the 'Trace block inconsistent with coverage map' check as it was
deemed to be too restrictive and not neccessary.
---
 tester/covoar/CoverageReaderQEMU.cc | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/tester/covoar/CoverageReaderQEMU.cc b/tester/covoar/CoverageReaderQEMU.cc
index 8e34f8f..37718ec 100644
--- a/tester/covoar/CoverageReaderQEMU.cc
+++ b/tester/covoar/CoverageReaderQEMU.cc
@@ -138,21 +138,7 @@ namespace Coverage {
 
         // Determine if additional branch information is available.
         if ( (entry->op & branchInfo) != 0 ) {
-          uint32_t  offset_e, offset_a;
           uint32_t  a = entry->pc + entry->size - 1;
-          if ((aCoverageMap->determineOffset( a, &offset_a ) != true)   ||
-             (aCoverageMap->determineOffset( entry->pc, &offset_e ) != true))
-          {
-            fprintf(
-              stderr,
-              "*** Trace block is inconsistent with coverage map\n"
-              "*** Trace block (0x%08x - 0x%08x) for %d bytes\n"
-              "*** Coverage map XXX \n",
-              entry->pc,
-              a,
-              entry->size
-            );
-          } else {
             while (!aCoverageMap->isStartOfInstruction(a))
               a--;
             if (entry->op & taken) {
@@ -160,7 +146,6 @@ namespace Coverage {
             } else if (entry->op & notTaken) {
               aCoverageMap->setWasNotTaken( a );
             }
-          }
         }
       }
     }
-- 
2.7.4




More information about the devel mailing list