[PATCH 3/9] covoar: Fix buffer overflow and fix br tag in html report.

Chris Johns chrisj at rtems.org
Sat Aug 26 02:01:23 UTC 2017


On 26/8/17 7:53 am, Cillian O'Donnell wrote:
> From: Hermann Felbinger <hermann19829 at gmail.com>
> 
> Co-Author: Krzysztof Miesowicz <krzysztof.miesowicz at gmail.com>
> ---
>  tester/covoar/ReportsBase.cc |  5 +++--
>  tester/covoar/ReportsHtml.cc | 46 ++++++++++++++++++++++----------------------
>  2 files changed, 26 insertions(+), 25 deletions(-)
> 
> diff --git a/tester/covoar/ReportsBase.cc b/tester/covoar/ReportsBase.cc
> index b61fc76..1989add 100644
> --- a/tester/covoar/ReportsBase.cc
> +++ b/tester/covoar/ReportsBase.cc
> @@ -213,7 +213,8 @@ void ReportsBase::WriteAnnotatedReport(
>        uint32_t     id = 0;
>        std::string  annotation = "";
>        std::string  line;
> -      char         textLine[150];
> +      const std::size_t LINE_LENGTH = 150;
> +      char         textLine[LINE_LENGTH];
>  

Formatting? The local vars appear to indent aligned so we should maintain that
formatting.

Chris



More information about the devel mailing list