libbsd include path issue

Christian Mauderer list at c-mauderer.de
Wed Jul 26 18:15:41 UTC 2017


Hello Chris,

I think I really have to start reading through this waf book. Thanks
again for the hint. You can find a second version of the patch which
uses the subst rule as a reply to this mail.

But before the patch gets merged, we maybe should wait till Sichen has
the port of openssl ready. I'll ask him that he includes the patch into
his future patch set. Till then, we still can discuss it ;-)

One further point: While discussing the port in a chat with Sichen, it
seemed that there are a lot of headers scattered around in the openssl
tree. So in that case it might could be a bad idea to have a recursive
copy because some files might get duplicated in a tree and the subtree.

I used the recursive search because some time later, the same recursive
search is used for installing the headers:

https://git.rtems.org/rtems-libbsd/tree/waf_generator.py?id=b43517be379decb653f4e3455afc1636a5a5c278#n629

Do you see any reason why we shouldn't put the recursive part of the
search into the builder.py. This would mean that we have for example a
line

        ('freebsd/include',               '**/*.h',            ''),

instead of the current

        ('freebsd/include',               '*.h',               ''),

That would make it easier to decide whether a recursive search should be
done or only a single file should be copied.

Kind regards

Christian



More information about the devel mailing list