[rtems-source-builder commit] 4.12: Update to use Newlib 2.5.0.20170228

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Mar 2 06:33:37 UTC 2017



On 02/03/17 00:12, Chris Johns wrote:
> On 01/03/2017 23:33, Sebastian Huber wrote:
>> Module:    rtems-source-builder
>> Branch:    master
>> Commit:    4c5eb8969451c4ea0997b3caa98bfe80fe15da69
>> Changeset: 
>> http://git.rtems.org/rtems-source-builder/commit/?id=4c5eb8969451c4ea0997b3caa98bfe80fe15da69
>>
>> Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
>> Date:      Wed Mar  1 07:30:37 2017 +0100
>>
>> 4.12: Update to use Newlib 2.5.0.20170228
>>
>
> Please do not make structural changes and configuration changes in the 
> same patch. They need to be separate patches.

The patch affects only the RTEMS 4.12 tool set.

>
> I do not like hashes being collected into a single file, there is no 
> common information that needs to be shared. Why has this change be made?

I do not like copy and paste. Why should we scatter the hashes 
throughout the configuration files multiple times?

>
> Please revert the change, split the patch and post for review.

I didn't break anything as far as I know. In case something is still 
wrong I prefer to fix individually.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list