rtems_fatal() as inline in a header file

[Pham, Phong]

Hi Developers,

Currently:
...\rtems\cpukit\sapi\include\rtems\fatal.h<file:///\\centos\rtems-dev\rtems_0508\rtems\cpukit\sapi\include\rtems\fatal.h>

is implemented as

RTEMS_NO_RETURN RTEMS_INLINE_ROUTINE void rtems_fatal(
  rtems_fatal_source fatal_source,
  rtems_fatal_code   error_code
)
{
  _Terminate( fatal_source, error_code );
}

I suggest to move the implementation to fatal.c and remove RTEMS_INLINE_ROUTINE.  I just don't see a benefit to implement it as inline.  Besides, it has disadvantages.  That is besides code size, during debugging, it simplifies the number of rtems_fatal symbol occurrences to 1.  Don't have to figure out which one is which.

bsp_fatal() is another one.

Phong.
Notice: This e-mail and any files transmitted with it may contain Data Device Corporation's privileged and proprietary information. It is intended solely for the use of the individual or entity to whom it is addressed. If you are not the named recipient of this transmission, any disclosure, copying, distribution or reliance on the contents of this message is prohibited. If you received this e-mail in error, please destroy it and any attached files and notify me immediately.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20170517/50f238fe/attachment.html>