[PATCH] tests: CONFIGURE_DISABLE_SMP_CONFIGURATION

Sebastian Huber sebastian.huber at embedded-brains.de
Tue May 16 07:54:29 UTC 2017


On 13/05/17 00:30, Chris Johns wrote:
> On 12/5/17 8:24 pm, Sebastian Huber wrote:
>> Mark tests that require review due to
>> CONFIGURE_DISABLE_SMP_CONFIGURATION.
> If a test fails it fails. I feel the test results need to correctly
> express the failures and we should not masks them in the way. I do not
> agree with changes that suppress a failure.
>
> I do not see SMP as any special over other reasons a test fails and I
> hope we do not start adding them. We exclude tests from being built
> because they do not fit into the target resources and that is fixed,
> bounded.

There are differences in non-SMP vs. SMP mode, e.g. disable thread 
preemption and interrupt level task modes are not supported. The tests 
are perfectly fine, but they use these explicit non-SMP features. You 
wanted more tests to run in the SMP mode if SMP is enabled. Now only 36 
tests are left over. They should be fixed to not use these features, but 
someone has to look at each test individually for this. This could be as 
easy as this:

https://git.rtems.org/rtems/commit/?id=00d982080cf1e630fea9c6e8b3a4e7a5be501781

I cannot fix everything instantly. I have to prioritize my work. There 
are a lot of other things to do and is this really the most important 
stuff right now before the RTEMS 4.12 release?

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list