[PATCH 00/27] Improve consistency of bsp_specs

Joel Sherrill joel at rtems.org
Wed Nov 29 19:42:11 UTC 2017


Hi

As the first step of removing the use of bsp_specs, I am
reviewing all bsp_spec files and working to improve their
consistency. Most of these patches are straightforward
to make the diff against the reference bsp_specs file
(erc32) smaller or easier to read. 

Reminder: bsp_specs is a gcc specific part of the source
tree. It is the single barrier to supporting clang/llvm.

Differences noted and dealt with:
  + endfile was sometimes before startfile
  + endfile sometimes was hard-coded and did not have -qrtems version
  + Typos: Odd spacing, "old_endfiles" typo, and *(old_endfiles) (not %)
  + nios2: Referenced crtnn.o not crtn.o (error)
  + sparc64: Did not use gcc provided crti.o/crtn.o

Beyond this step, there are a few BSPs which have uniquely
complicated bsp_specs files which will require attention. 

There are a few inconsistencies left which we will need to 
address:

  + some bsp_specs include both qrtems and nostdlib options.
    I don't think these are necessary and should be eliminated.
  + What to do about PowerPC have its own rtems_crt[in].o? This
    is the only target we provide this file for. 

Beyond that, I saw a few patterns that will further reduce the
dependence on bsp_specs:

  + Specify entry point in linkcmds, not bsp_specs
  + Specify any undefined symbols in linkcmds, not bsp_specs

After addressing those last two, we can experiment with some BSPs
having empty bsp_specs files.

I would welcome help reducing the differences between the bsp_specs
so they are easier to eliminate.

Thanks.

--joel

Joel Sherrill (27):
  TLL6527M/bsp_specs: Fix spacing and typo
  bf537Stamp/bsp_specs: Fix spacing and typo
  eZKit533/bsp_specs: Fix spacing and typo
  epiphany_sim/bsp_specs: Fix spacing and typo
  nios2_iss/bsp_specs: Fix typo
  generic_or1k/bsp_specs: Fix spacing and typo
  pc386/bsp_specs: Reorder and improve consistency
  m32cbsp/bsp_specs: Reorder and improve consistency
  hurricane/bsp_specs: Improve consistency
  moxiesim/bsp_specs: Reorder and improve consistency
  beatnik/bsp_specs: Reorder and improve consistency
  gen83xx/bsp_specs: Reorder and improve consistency
  haleakala/bsp_specs: Reorder and improve consistency
  motorola_powerpc/bsp_specs: Reorder and improve consistency
  mvme3100/bsp_specsReorder and improve consistency
  mvme5500/bsp_specs: Reorder and improve consistency
  psim/bsp_specs: Reorder and improve consistency
  qemuppc/bsp_specs: Reorder and improve consistency
  qoriq/bsp_specs: Reorder and improve consistency
  virtex/bsp_specs: Reorder and improve consistency
  riscv_generic/bsp_specs: Fix spacing and typo
  erc32/bsp_specs: Reorder and improve consistency
  leon2/bsp_specs: Reorder and improve consistency
  leon3/bsp_specs: Reorder and improve consistency
  sparc64/*/bsp_specs, shared/.../start.S: Use GCC init/fini, improve
    consistency
  gdbv850sim/bsp_specs: Reorder and improve consistency
  arm/*/bsp_specs: Remove extra space to increase consistency

 c/src/lib/libbsp/arm/altera-cyclone-v/bsp_specs     |  2 +-
 c/src/lib/libbsp/arm/atsam/bsp_specs                |  2 +-
 c/src/lib/libbsp/arm/beagle/bsp_specs               |  2 +-
 c/src/lib/libbsp/arm/csb336/bsp_specs               |  2 +-
 c/src/lib/libbsp/arm/csb337/bsp_specs               |  2 +-
 c/src/lib/libbsp/arm/edb7312/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/gdbarmsim/bsp_specs            |  2 +-
 c/src/lib/libbsp/arm/gumstix/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/imx/bsp_specs                  |  2 +-
 c/src/lib/libbsp/arm/lm3s69xx/bsp_specs             |  2 +-
 c/src/lib/libbsp/arm/lpc176x/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/lpc24xx/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/lpc32xx/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/raspberrypi/bsp_specs          |  2 +-
 c/src/lib/libbsp/arm/realview-pbx-a9/bsp_specs      |  2 +-
 c/src/lib/libbsp/arm/rtl22xx/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/smdk2410/bsp_specs             |  2 +-
 c/src/lib/libbsp/arm/stm32f4/bsp_specs              |  2 +-
 c/src/lib/libbsp/arm/tms570/bsp_specs               |  2 +-
 c/src/lib/libbsp/arm/xilinx-zynq/bsp_specs          |  2 +-
 c/src/lib/libbsp/bfin/TLL6527M/bsp_specs            |  2 +-
 c/src/lib/libbsp/bfin/bf537Stamp/bsp_specs          |  2 +-
 c/src/lib/libbsp/bfin/eZKit533/bsp_specs            |  2 +-
 c/src/lib/libbsp/epiphany/epiphany_sim/bsp_specs    |  2 +-
 c/src/lib/libbsp/i386/pc386/bsp_specs               |  6 +++---
 c/src/lib/libbsp/m32c/m32cbsp/bsp_specs             |  8 +++-----
 c/src/lib/libbsp/mips/hurricane/bsp_specs           |  6 +++---
 c/src/lib/libbsp/moxie/moxiesim/bsp_specs           |  4 +++-
 c/src/lib/libbsp/nios2/nios2_iss/bsp_specs          |  2 +-
 c/src/lib/libbsp/or1k/generic_or1k/bsp_specs        |  2 +-
 c/src/lib/libbsp/powerpc/beatnik/bsp_specs          |  6 +++---
 c/src/lib/libbsp/powerpc/gen83xx/bsp_specs          |  4 ++--
 c/src/lib/libbsp/powerpc/haleakala/bsp_specs        |  4 ++--
 c/src/lib/libbsp/powerpc/motorola_powerpc/bsp_specs |  6 +++---
 c/src/lib/libbsp/powerpc/mvme3100/bsp_specs         |  6 +++---
 c/src/lib/libbsp/powerpc/mvme5500/bsp_specs         |  6 +++---
 c/src/lib/libbsp/powerpc/psim/bsp_specs             |  6 +++---
 c/src/lib/libbsp/powerpc/qemuppc/bsp_specs          |  6 +++---
 c/src/lib/libbsp/powerpc/qoriq/bsp_specs            |  5 ++---
 c/src/lib/libbsp/powerpc/virtex/bsp_specs           |  3 +--
 c/src/lib/libbsp/riscv/riscv_generic/bsp_specs      |  2 +-
 c/src/lib/libbsp/sparc/erc32/bsp_specs              |  6 +++---
 c/src/lib/libbsp/sparc/leon2/bsp_specs              |  6 +++---
 c/src/lib/libbsp/sparc/leon3/bsp_specs              |  6 +++---
 c/src/lib/libbsp/sparc64/niagara/bsp_specs          | 10 ++++------
 c/src/lib/libbsp/sparc64/shared/start/start.S       | 14 --------------
 c/src/lib/libbsp/sparc64/usiii/bsp_specs            | 10 ++++------
 c/src/lib/libbsp/v850/gdbv850sim/bsp_specs          |  8 +++-----
 48 files changed, 84 insertions(+), 106 deletions(-)

-- 
1.8.3.1



More information about the devel mailing list