[PATCH 4/6] bsps: Move version.c and use bspopts.h

[Sebastian Huber]

On 04/04/18 09:55, Chris Johns wrote:
> If you can restrict yourself to just automake defined functionality you stand a
> chance, if you cannot you step into implementation issues. Please review the
> patch below.
> [...]
> An example of a breakage with the latest automake is:
>
> diff --git a/c/src/configure.ac b/c/src/configure.ac
> index ff7c7752ed..705fd4af54 100644
> --- a/c/src/configure.ac
> +++ b/c/src/configure.ac
> @@ -125,8 +125,11 @@ RTEMS_BSP_CONFIG_SUBDIR(
>      [test x"$multilib" = xno])
>
>    ## Note: the order of the directories below is essential
> -AC_CONFIG_SUBDIRS([make])
> -BSP_SUBDIRS="$BSP_SUBDIRS make"
> +## Note note: this whole implementation is a bad hack and is broken
> +## in the latest automake as would be expected, the order of post commands
> +## has changed so as a result we need to use the "hack" and not the documented
> +## standard way.
> +RTEMS_BSP_CONFIG_SUBDIR([make],[make],[],[true])
>
>    # Is there code where there should be for this BSP?
>    RTEMS_CPU_SUBDIRS([lib/libbsp])
>
> This is fragile stuff. Just check the comment in the file containing
> RTEMS_BSP_CONFIG_SUBDIR.

Sorry, Chris. I cannot review this Autoconf/Automake stuff. I have no 
idea how it works internally. I work with trial and error mostly in this 
domain.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.