[PATCH] bootstrap: Do not create acinlude.m4 files

[Chris Johns]

On 23/04/2018 16:13, Sebastian Huber wrote:
> On 23/04/18 08:05, Chris Johns wrote:
>> On 23/04/2018 15:45, Sebastian Huber wrote:
>>> The generation of files which are part of the Git repository should be
>>> done by the normal bootstrap script only since this is a RTEMS
>>> maintainer job.
>> Really? I am a bit lost by this change. I have never understood why acinclude.m4
>> is in the repo.
> 
> I have never understood why the build system must be so complicated.

I doubt we will ever will know.

> The fact
> is, that the acinclude.m4 files are in the repository currently.
>>
>>> This patch is a part of the BSP source reorganization.
>> I am sorry I do not see the relationship to this task.
> 
> The BSP source and build files move to bsps. With this patch
> 
> https://lists.rtems.org/pipermail/devel/2018-April/021136.html
> 
> the sb-bootstrap destroys the acinclude.m4 files.

OK.

>>
>> Could you please explain what you are changing in this task that breaks the RSB
>> bootstrap script? I assume you are updating the shell script?
>>
>> The RSB script is used when releasing so not keeping them in sync will break
>> releasing.
> 
> All files in the repository should be correct during the release.

Sure lets look at that a bit more and ask ....

> A RSB script
> which modifies files of the repository is an extra error source.

Why not remove `generate_bspdir_acinclude()` from the bootstrap script and we
maintained the file by hand? After all adding or removing BSPs from RTEMS is not
done that often and is a manual process anyway.

Doing this also means both processes to bootstrap are the same which is a good
outcome.

Chris