[PATCH] rfs: Remove erroneous call of rtems_disk_release()

Sebastian Huber sebastian.huber at embedded-brains.de
Mon Aug 6 13:21:05 UTC 2018


On 06/08/18 15:03, Joel Sherrill wrote:
>
>
> On Mon, Aug 6, 2018, 3:01 AM Sebastian Huber 
> <sebastian.huber at embedded-brains.de 
> <mailto:sebastian.huber at embedded-brains.de>> wrote:
>
>     On 06/08/18 09:47, Chris Johns wrote:
>     > On 06/08/2018 16:13, Sebastian Huber wrote:
>     >> this needs a back port to 4.11 and 4.10.
>     >>
>     > I saw the ticket for 4.10 and assumed the patch was for 4.10. We
>     separate
>     > tickets for each branch.
>
>     This makes the ticket handling a bit more complicated. Why is this
>     necessary? Are different tickets for the same bug really great? I
>     think
>     the rational is that if a bug is fixed in version x, then it is also
>     fixed in all versions x + i.
>
>
> It is a human assumption but it doesn't work out right for using Trac 
> to generate release reports. Each ticket has a single milestone. So it 
> would be fixed in 4.10.n but we don't know where along the 4.11 series 
> it got fixed based on Trac 4.11 release reports.

Creating an arbitrary number of tickets for one bug looks like a 
workaround for a Trac or release note generator shortcoming. Each ticket 
should probably have a list of milestones.

There should be definitely some guideline for this since this was at 
least not obvious to me.

Chris used the blocked by field to link such tickets:

https://devel.rtems.org/ticket/3323

I used update commits in the past and a close commit for the first 
milestone, e.g.

https://devel.rtems.org/ticket/2622

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list