[rtems-libbsd commit] userspace-header-gen.py: Sort file content

Sebastian Huber sebastian.huber at embedded-brains.de
Fri Aug 31 05:02:03 UTC 2018


On 31/08/18 02:15, Chris Johns wrote:
> On 28/8/18 10:35 pm, Sebastian Huber wrote:
>> Module:    rtems-libbsd
>> Branch:    master
>> Commit:    b2e1123733db8fd1a83a893e980a9fe4da357bb6
>> Changeset: http://git.rtems.org/rtems-libbsd/commit/?id=b2e1123733db8fd1a83a893e980a9fe4da357bb6
>>
>> Author:    Sebastian Huber <sebastian.huber at embedded-brains.de>
>> Date:      Tue Aug 28 14:14:27 2018 +0200
>>
>> userspace-header-gen.py: Sort file content
>>
>> Sort the file content to make it less dependent on compiler code
>> generation variances.
>>
>> ---
>>
>>   userspace-header-gen.py | 29 +++++++++++++++++++++--------
>>   1 file changed, 21 insertions(+), 8 deletions(-)
>>
>> diff --git a/userspace-header-gen.py b/userspace-header-gen.py
>> index f41feb4..8c7ef76 100755
>> --- a/userspace-header-gen.py
>> +++ b/userspace-header-gen.py
>> @@ -1,4 +1,4 @@
>> -#!/usr/bin/env python
>> +#!/usr/bin/env python3
> I think this type of change should have a discussion. For the record I think the
> platform's default 'python' is what we use. When the plaform, distro, OS or
> whatever moves we move with it. I do not wish to spend time and energy on the
> merits of python versions, we should support both while they are defaults on any
> platforms we support.
>
> Also the commit message does not cover this change and it is something that
> should be noted in the message with a ticket.
>
> Please revert just this bit.

Sorry, this part of the patch was an accident. Thanks for spotting.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.




More information about the devel mailing list