Contribute to project

[Abhinav Jain]

Sir,

I have gone through the code and tried to trace out where the error is
occurring. I also read about the git status command and the problem which I
was able to figure out from this was with the git status command only.
I discussed this with Chris sir and he suggested me to make a different
function to check the presence of the .git file and in place of checking
the validity of path everywhere, this function is to be called as this
provides a surety that the git status is not reflecting the status of a
parent directory.

Thanks and Regards
Abhinav Jain

On Tue, Feb 20, 2018 at 7:22 PM, Gedare Bloom <gedare at rtems.org> wrote:

> On Sun, Feb 18, 2018 at 3:19 AM, Abhinav Jain <jainab.2009 at gmail.com>
> wrote:
> > Sir,
> >
> > I have gone through the code concerning the issue raised. I also read
> about
> > the working of git status command and the problem that I am able to
> figure
> > out is that although the existing code is able to check whether the
> current
> > path exists or not but since it is relying on git status to check whether
> > the .git file is available or not, a problem is there. The git status
> checks
> > the current directory for the .git file but in case the current directory
> > doesn't have the .git file, it will look for it in the parent directory
> and
> > if found there it will return True, which voids the purpose.
> > So, I think, if a second check is given to validate whether the current
> > directory contains .git file or not will solve the issue.
> > So the code may be:
> > def valid(self):
> >         if path.exists(self.path):
> > if path.exists(path.join(self.path, ".git")):
> >             ec, output = self._run(['status'])
> >             return ec == 0
> >         return False
> > I request you to please guide me whether I proceeded in a right way or
> not.
> >
> That appears to be the code from the patch on the Trac, with Chris'
> comment to replace os.path.join with path.join. But, have you been
> able to (1) reproduce the problem, and (2) confirm this fixes it?
>
> >
> > Thanks and Regards
> > Abhinav Jain
> >
> > On Tue, Feb 13, 2018 at 10:50 AM, Abhinav Jain <jainab.2009 at gmail.com>
> > wrote:
> >>
> >> Sir,
> >>
> >> Thanks for the guidance. I will study the code available and will try to
> >> resolve the issue as soon as possible.
> >>
> >> Thanks and Regards
> >> Abhinav Jain
> >>
> >> On Tue, Feb 13, 2018 at 4:47 AM, Chris Johns <chrisj at rtems.org> wrote:
> >>>
> >>> On 13/02/2018 06:05, Gedare Bloom wrote:
> >>> > Abhinav,
> >>> >
> >>> > Attempt to reproduce the reported problem, try out the patch and see
> >>> > if it works. I see this was reported for 4.10. See if the problem
> also
> >>> > affects 4.11, master, and if the fix works for them too.
> >>>
> >>> I suspect it is common to all branches.
> >>>
> >>> >
> >>> > On Mon, Feb 12, 2018 at 11:55 AM, Abhinav Jain <
> jainab.2009 at gmail.com>
> >>> > wrote:
> >>> >> Sir,
> >>> >>
> >>> >> I have gone through the projects available in the link provided by
> you
> >>> >> and I
> >>> >> am interested in an issue (RSB can sometimes change the wrong local
> >>> >> git
> >>> >> repository (includes a fix).) listed there.
> >>> >> Link: https://devel.rtems.org/ticket/2522#no1
> >>> >> I request you to please provide some more information regarding this
> >>> >> so that
> >>> >> I can proceed with the coding part.
> >>> >>
> >>>
> >>> As Gedare suggests take a look at the master and 4.11 branches and if
> >>> present
> >>> work I suggest you work on the master branch and then we can take
> git.py
> >>> and
> >>> back port to 4.11 and 4.10 by simply coping git.py to those branches.
> >>>
> >>> Chris
> >>
> >>
> >
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.rtems.org/pipermail/devel/attachments/20180220/b544a4cf/attachment-0001.html>