[PATCH 0/3] v3 - Paravirtualization Patch Series

Chris Johns chrisj at rtems.org
Thu Feb 22 05:06:19 UTC 2018

On 22/02/2018 13:37, Sebastian Huber wrote:
>> Architecture-specific names should use an ARCH_ or _Arch prefix and not CPU_ARCH
>> or _CPU_Arch.
>> This
>> is an architecture-specific implementation detail which doesn't propagate to
>> generic files, e.g. rtems/score/isrlevel.h, so it should not be introduced from
>> my point of view.
>> I don't think it is worth to add a rtems/score/paravirt.h for each architecture.
>> The changes introduced by RTEMS_PARAVIRT are too small to justify this.  I am
>> also not sure if you can encapsulate this in one header in all cases.
> Please don't ignore this.

I felt spreading the RTEMS_PARAVIRT across the code was hiding the reason in
some cases. When I reviewed the v2 patches I felt changes in a specific area
needed more information to aid long term maintenance. For example look at the
ARM thread id register. It is clear what is happening and if that change flows
out to other parts of the system it is clear what is happening if there is a
dependence on that register.


More information about the devel mailing list