no-preinstall: Ready for final review

Gedare Bloom gedare at rtems.org
Thu Jan 18 15:06:53 UTC 2018


On Wed, Jan 17, 2018 at 2:24 AM, Sebastian Huber
<sebastian.huber at embedded-brains.de> wrote:
> Hello,
>
> the no-preinstall branch is now in a good shape.
>
> https://git.rtems.org/sebh/rtems.git/log/?h=no-preinstall
>
> Please review this work. The next step would be to squash all commits on
> this branch, write a proper commit message and push it to the master.
>
Hello Sebastian,

I checked it out, built erc32, ran erc32 from the build, installed the
bsp, and ran it again fine using rtems-tools/tester.

However, when I try to waf-configure examples-v2, I get a problem that
rtems/score/cpuopts.h is not found. When I look in my installed tree,
I do not find the file:

$ find /opt/rtems-5 -name cpuopts.h
$ find /opt/rtems-5 -name include
./sparc-rtems5/erc32/lib/include

I do see it in my build tree:
~/work/rtems/builds/b-erc32-5$ find . -name cpuopts.h
./sparc-rtems5/c/erc32/include/rtems/score/cpuopts.h

Relatedly, I don't see the bspopts.h file in the installed tree
either. I do see it in the build tree, in a different location from
the rest of the includes:
~/work/rtems/builds/b-erc32-5$ find . -name bspopts.h
./sparc-rtems5/c/erc32/lib/libbsp/sparc/erc32/include/bspopts.h

I also took a quick look through the commits, and I have a small nit.
Might I suggest "headers.sh" and "headers.am" instead of "header.sh"
and "header.am"?

-Gedare

> --
> Sebastian Huber, embedded brains GmbH
>
> Address : Dornierstr. 4, D-82178 Puchheim, Germany
> Phone   : +49 89 189 47 41-16
> Fax     : +49 89 189 47 41-09
> E-Mail  : sebastian.huber at embedded-brains.de
> PGP     : Public key available on request.
>
> Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.
>
> _______________________________________________
> devel mailing list
> devel at rtems.org
> http://lists.rtems.org/mailman/listinfo/devel


More information about the devel mailing list