no-preinstall: Ready for final review

Chris Johns chrisj at rtems.org
Thu Jan 18 20:34:25 UTC 2018


On 19/1/18 3:37 am, Gedare Bloom wrote:
> On Thu, Jan 18, 2018 at 11:36 AM, Sebastian Huber
> <sebastian.huber at embedded-brains.de> wrote:
>>
>>
>> ----- Am 18. Jan 2018 um 16:06 schrieb Gedare Bloom gedare at rtems.org:
>>
>> [...]
>>> I also took a quick look through the commits, and I have a small nit.
>>> Might I suggest "headers.sh" and "headers.am" instead of "header.sh"
>>> and "header.am"?
>>
>> I want to add this stuff to the bootstrap script as a -p replacement.
> 
> That's fine with me. I would still prefer the generated file be named
> headers.am to reflect the purpose of defining the (multiple) include
> headers.

I do not think we should do this. I would prefer any addition is done by hand to
avoid picking up any header sitting in a developers tree. The initial bulk
injection should be a one off and after that API additions need consideration.

I would prefer `bootstrap -p` becomes a nop.

Chris



More information about the devel mailing list