no-preinstall: Ready for final review

[Sebastian Huber]

On 18/01/18 21:57, Gedare Bloom wrote:
> On Thu, Jan 18, 2018 at 3:34 PM, Chris Johns<chrisj at rtems.org>  wrote:
>> On 19/1/18 3:37 am, Gedare Bloom wrote:
>>> On Thu, Jan 18, 2018 at 11:36 AM, Sebastian Huber
>>> <sebastian.huber at embedded-brains.de>  wrote:
>>>> ----- Am 18. Jan 2018 um 16:06 schrieb Gedare Bloomgedare at rtems.org:
>>>>
>>>> [...]
>>>>> I also took a quick look through the commits, and I have a small nit.
>>>>> Might I suggest "headers.sh" and "headers.am" instead of "header.sh"
>>>>> and "header.am"?
>>>> I want to add this stuff to the bootstrap script as a -p replacement.
>>> That's fine with me. I would still prefer the generated file be named
>>> headers.am to reflect the purpose of defining the (multiple) include
>>> headers.
>> I do not think we should do this. I would prefer any addition is done by hand to
>> avoid picking up any header sitting in a developers tree. The initial bulk
>> injection should be a one off and after that API additions need consideration.
>>
> That's fair too. It should not be such a common case to add to the
> headers.am files. One thing though, the file should have a comment
> injected at the top to note that it is a generated file, not to edit
> it (and how to regenerate it).
>

I added this comment to the headers.am:

## This file was generated by "./boostrap -H".

I moved the header.sh to bootstrap via the new -H option. The headers.am 
should be maintained by "./bootstrap -H". This ensures that the 
directory tree and the build system is in synchronization. Header file 
changes in BSPs are quite common. The workflow is like this:

$ touch bsps/sparc/erc32/include/bsp/foobar.h
$ ./bootstrap -H
Files headers.am.new and bsps/sparc/erc32/include/../headers.am differ
$ git status
On branch no-preinstall
Your branch is up-to-date with 'sh/no-preinstall'.
Changes not staged for commit:
   (use "git add <file>..." to update what will be committed)
   (use "git checkout -- <file>..." to discard changes in working directory)

         modified:   bsps/sparc/erc32/headers.am

Untracked files:
   (use "git add <file>..." to include in what will be committed)

         bsps/sparc/erc32/include/bsp/foobar.h

no changes added to commit (use "git add" and/or "git commit -a")

Changes in headers.am are part of the patch set and can be reviewed easily.

-- 
Sebastian Huber, embedded brains GmbH

Address : Dornierstr. 4, D-82178 Puchheim, Germany
Phone   : +49 89 189 47 41-16
Fax     : +49 89 189 47 41-09
E-Mail  : sebastian.huber at embedded-brains.de
PGP     : Public key available on request.

Diese Nachricht ist keine geschäftliche Mitteilung im Sinne des EHUG.