[GSoC - x86_64] Current state, next steps, and minimal mergable BSP

Amaan Cheval amaan.cheval at gmail.com
Wed Jul 4 12:34:22 UTC 2018


Hi!

Quick question - when I squash and submit the patches to devel, do 2
commits make sense?
1. Initial BSP that can build completely and get to the user's Init task
2. NS16550 console driver that lets printf/printk work

Another question - my code has a bunch of XXX comments in it - are we
okay to leave that as-is? Should I be changing some to TODOs, as
appropriate (seems like unnecessary effort since the BSP is still in
flux a fair bit).

I've made a WIP pull-request on Github to make some early feedback
easier (patches on the mailing list would likely feel cluttered for
this much code, I think). There's a bunch of clean-up left before I'll
squash (see the to-do in the PR), but I'd appreciate a skimmed review
if possible for anything else I need to do pre-merge:
https://github.com/AmaanC/rtems-gsoc18/pull/1

Let me know what you think!

On Sun, Jul 1, 2018 at 7:06 AM, Chris Johns <chrisj at rtems.org> wrote:
>
>> On 29 Jun 2018, at 11:37 pm, Amaan Cheval <amaan.cheval at gmail.com> wrote:
>>
>> On Fri, Jun 29, 2018 at 6:46 PM, Sebastian Huber
>> <sebastian.huber at embedded-brains.de> wrote:
>>>
>>> From my point of view we can merge this stuff right now if the license and
>>> copyright status is clear of all files and it builds all tests.
>>
>> Noted. I'll start cleaning right away, then, unless someone disagrees soon.
>>
>
> I am happy to see this code merged as soon as possible.
>
> Chris


More information about the devel mailing list