[PATCH 24/29] jffs2: Remove jffs2_{get,set,remove}xattr macros

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Jul 5 07:49:44 UTC 2018


From: Andreas Gruenbacher <agruenba at redhat.com>

When CONFIG_JFFS2_FS_XATTR is off, jffs2_xattr_handlers is defined as
NULL. With sb->s_xattr == NULL, the generic_{get,set,remove}xattr
functions produce the same result as setting the {get,set,remove}xattr
inode operations to NULL, so there is no need for these macros.

Signed-off-by: Andreas Gruenbacher <agruenba at redhat.com>
Signed-off-by: Al Viro <viro at zeniv.linux.org.uk>

0	6	cpukit/libfs/src/jffs2/src/xattr.h

diff --git a/cpukit/libfs/src/jffs2/src/xattr.h b/cpukit/libfs/src/jffs2/src/xattr.h
index 467ff376ee..720007b2fd 100644
--- a/cpukit/libfs/src/jffs2/src/xattr.h
+++ b/cpukit/libfs/src/jffs2/src/xattr.h
@@ -99,9 +99,6 @@ extern const struct xattr_handler jffs2_user_xattr_handler;
 extern const struct xattr_handler jffs2_trusted_xattr_handler;
 
 extern ssize_t jffs2_listxattr(struct dentry *, char *, size_t);
-#define jffs2_getxattr		generic_getxattr
-#define jffs2_setxattr		generic_setxattr
-#define jffs2_removexattr	generic_removexattr
 
 #else
 
@@ -116,9 +113,6 @@ extern ssize_t jffs2_listxattr(struct dentry *, char *, size_t);
 
 #define jffs2_xattr_handlers	NULL
 #define jffs2_listxattr		NULL
-#define jffs2_getxattr		NULL
-#define jffs2_setxattr		NULL
-#define jffs2_removexattr	NULL
 
 #endif /* CONFIG_JFFS2_FS_XATTR */
 
-- 
2.13.7



More information about the devel mailing list