[PATCH 11/29] initramfs: support initramfs that is bigger than 2GiB

Sebastian Huber sebastian.huber at embedded-brains.de
Thu Jul 5 07:49:31 UTC 2018


From: Yinghai Lu <yinghai at kernel.org>

Now with 64bit bzImage and kexec tools, we support ramdisk that size is
bigger than 2g, as we could put it above 4G.

Found compressed initramfs image could not be decompressed properly.  It
turns out that image length is int during decompress detection, and it
will become < 0 when length is more than 2G.  Furthermore, during
decompressing len as int is used for inbuf count, that has problem too.

Change len to long, that should be ok as on 32 bit platform long is
32bits.

Tested with following compressed initramfs image as root with kexec.
	gzip, bzip2, xz, lzma, lzop, lz4.
run time for populate_rootfs():
   size        name       Nehalem-EX  Westmere-EX  Ivybridge-EX
 9034400256 root_img     :   26s           24s          30s
 3561095057 root_img.lz4 :   28s           27s          27s
 3459554629 root_img.lzo :   29s           29s          28s
 3219399480 root_img.gz  :   64s           62s          49s
 2251594592 root_img.xz  :  262s          260s         183s
 2226366598 root_img.lzma:  386s          376s         277s
 2901482513 root_img.bz2 :  635s          599s

Signed-off-by: Yinghai Lu <yinghai at kernel.org>
Cc: "H. Peter Anvin" <hpa at zytor.com>
Cc: Ingo Molnar <mingo at elte.hu>
Cc: Rashika Kheria <rashika.kheria at gmail.com>
Cc: Josh Triplett <josh at joshtriplett.org>
Cc: Kyungsik Lee <kyungsik.lee at lge.com>
Cc: P J P <ppandit at redhat.com>
Cc: Al Viro <viro at zeniv.linux.org.uk>
Cc: Tetsuo Handa <penguin-kernel at i-love.sakura.ne.jp>
Cc: "Daniel M. Weeks" <dan at danweeks.net>
Cc: Alexandre Courbot <acourbot at nvidia.com>
Cc: Jan Beulich <JBeulich at suse.com>
Signed-off-by: Andrew Morton <akpm at linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds at linux-foundation.org>

4	3	cpukit/libfs/src/jffs2/src/compr_zlib.c

diff --git a/cpukit/libfs/src/jffs2/src/compr_zlib.c b/cpukit/libfs/src/jffs2/src/compr_zlib.c
index ec640c125a..6f5d0d3956 100644
--- a/cpukit/libfs/src/jffs2/src/compr_zlib.c
+++ b/cpukit/libfs/src/jffs2/src/compr_zlib.c
@@ -74,11 +74,12 @@ uint16_t rtems_jffs2_compressor_zlib_compress(
 
 	while (def_strm->total_out < *dstlen - STREAM_END_SPACE && def_strm->total_in < *sourcelen) {
 		def_strm->avail_out = *dstlen - (def_strm->total_out + STREAM_END_SPACE);
-		def_strm->avail_in = min((unsigned)(*sourcelen-def_strm->total_in), def_strm->avail_out);
-		jffs2_dbg(1, "calling deflate with avail_in %d, avail_out %d\n",
+		def_strm->avail_in = min_t(unsigned long,
+			(*sourcelen-def_strm->total_in), def_strm->avail_out);
+		jffs2_dbg(1, "calling deflate with avail_in %ld, avail_out %ld\n",
 			  def_strm->avail_in, def_strm->avail_out);
 		ret = zlib_deflate(def_strm, Z_PARTIAL_FLUSH);
-		jffs2_dbg(1, "deflate returned with avail_in %d, avail_out %d, total_in %ld, total_out %ld\n",
+		jffs2_dbg(1, "deflate returned with avail_in %ld, avail_out %ld, total_in %ld, total_out %ld\n",
 			  def_strm->avail_in, def_strm->avail_out,
 			  def_strm->total_in, def_strm->total_out);
 		if (ret != Z_OK) {
-- 
2.13.7



More information about the devel mailing list